Reap DictLookupMetric (#2682)

Summary:
Pull Request resolved: #2682

This is unused after D61397457; in general we are consolidating computation on `BenchmarkRunner` rather than in metrics. Files will be deleted after confirming that tests pass.

Reviewed By: saitcakmak, Balandat

Differential Revision: D61397737

fbshipit-source-id: e838abf586c8854fb887f10eb2e6489f49db4a96

ax/storage/json_store/registry.py

@@ -78,7 +78,6 @@
 from ax.metrics.branin import AugmentedBraninMetric, BraninMetric, NegativeBraninMetric
 from ax.metrics.branin_map import BraninTimestampMapMetric
 from ax.metrics.chemistry import ChemistryMetric, ChemistryProblemType
-from ax.metrics.dict_lookup import DictLookupMetric
 from ax.metrics.factorial import FactorialMetric
 from ax.metrics.hartmann6 import AugmentedHartmann6Metric, Hartmann6Metric
 from ax.metrics.l2norm import L2NormMetric
@@ -199,7 +198,6 @@
     ChainedInputTransform: botorch_component_to_dict,
     ChoiceParameter: choice_parameter_to_dict,
     Data: data_to_dict,
-    DictLookupMetric: metric_to_dict,
     Experiment: experiment_to_dict,
     FactorialMetric: metric_to_dict,
     FixedParameter: fixed_parameter_to_dict,
@@ -318,7 +316,6 @@
     "ComparisonOp": ComparisonOp,
     "Data": Data,
     "DataType": DataType,
-    "DictLookupMetric": DictLookupMetric,
     "DomainType": DomainType,
     "Experiment": Experiment,
     "FactorialMetric": FactorialMetric,

ax/storage/json_store/tests/test_json_store.py

@@ -71,7 +71,6 @@
     get_chained_input_transform,
     get_choice_parameter,
     get_default_scheduler_options,
-    get_dict_lookup_metric,
     get_experiment_with_batch_and_single_trial,
     get_experiment_with_data,
     get_experiment_with_map_data,
@@ -153,7 +152,6 @@
     ("BraninMetric", get_branin_metric),
     ("ChainedInputTransform", get_chained_input_transform),
     ("ChoiceParameter", get_choice_parameter),
-    ("DictLookupMetric", get_dict_lookup_metric),
     ("Experiment", get_experiment_with_batch_and_single_trial),
     ("Experiment", get_experiment_with_trial_with_ttl),
     ("Experiment", get_experiment_with_data),

ax/utils/testing/core_stubs.py

@@ -82,7 +82,6 @@
 from ax.global_stopping.strategies.improvement import ImprovementGlobalStoppingStrategy
 from ax.metrics.branin import AugmentedBraninMetric, BraninMetric
 from ax.metrics.branin_map import BraninTimestampMapMetric
-from ax.metrics.dict_lookup import DictLookupMetric
 from ax.metrics.factorial import FactorialMetric
 from ax.metrics.hartmann6 import AugmentedHartmann6Metric, Hartmann6Metric
 from ax.modelbridge.factory import Cont_X_trans, get_factorial, get_sobol, Models
@@ -1522,17 +1521,6 @@ def get_factorial_metric(name: str = "success_metric") -> FactorialMetric:
     return FactorialMetric(name=name, coefficients=coefficients, batch_size=int(1e4))
 
 
-def get_dict_lookup_metric() -> DictLookupMetric:
-    return DictLookupMetric(
-        name="test metric",
-        param_names=["p1", "p2"],
-        lookup_dict={
-            (0, 0): 0,
-            (0, 1): 1,
-        },
-    )
-
-
 ##############################
 # Outcome Constraints
 ##############################