Skip to content

Commit

Permalink
fb dependency snuck into OSS code (#1950)
Browse files Browse the repository at this point in the history
Summary:
Getting rid of a errant dep that's breaking builds.

Pull Request resolved: #1950

Reviewed By: Balandat

Differential Revision: D50905543

fbshipit-source-id: 6de752201c8541546ed11d5cd9285b53abd30adf
  • Loading branch information
Bernie Beckerman authored and facebook-github-bot committed Nov 2, 2023
1 parent 47cded9 commit 7d8a0be
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions ax/storage/sqa_store/encoder.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
from ax.core.search_space import RobustSearchSpace, SearchSpace
from ax.core.trial import Trial
from ax.exceptions.storage import SQAEncodeError
from ax.fb.runners.chain_runner import ChainRunner
from ax.modelbridge.generation_strategy import GenerationStrategy
from ax.storage.json_store.encoder import object_to_json
from ax.storage.sqa_store.sqa_classes import (
Expand Down Expand Up @@ -880,16 +879,6 @@ def runner_to_sqa(
f"{self.EXTRA_REGISTRY_ERROR_NOTE}"
)
properties = runner_class.serialize_init_args(obj=runner)
if isinstance(runner, ChainRunner):
stage_sequence = []
for stage in properties["stage_sequence"]:
stage_dict = object_to_json(
stage,
encoder_registry=self.config.json_encoder_registry,
class_encoder_registry=self.config.json_class_encoder_registry,
)
stage_sequence.append(stage_dict)
properties["stage_sequence"] = stage_sequence
# pyre-fixme: Expected `Base` for 1st...t `typing.Type[Runner]`.
runner_class: SQARunner = self.config.class_to_sqa_class[Runner]
# pyre-fixme[29]: `SQARunner` is not a function.
Expand Down

0 comments on commit 7d8a0be

Please sign in to comment.