Skip to content

Commit

Permalink
Add extra space in CanGenerateCandidatesAnalysisn for better markdown…
Browse files Browse the repository at this point in the history
… support (#2969)

Summary:
Pull Request resolved: #2969

It doesn't always break in all renderings for a single space

Reviewed By: ItsMrLin

Differential Revision: D64982270

fbshipit-source-id: 82d2e7efafbb01057b67d9425540913bc725bfcd
  • Loading branch information
Daniel Cohen authored and facebook-github-bot committed Oct 25, 2024
1 parent 103fdb0 commit 5e115f8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion ax/analysis/healthcheck/can_generate_candidates.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

class CanGenerateCandidatesAnalysis(HealthcheckAnalysis):
REASON_PREFIX: str = "This experiment cannot generate candidates.\nREASON: "
LAST_RUN_TEMPLATE: str = "\nLAST TRIAL RUN: {days} day(s) ago"
LAST_RUN_TEMPLATE: str = "\n\nLAST TRIAL RUN: {days} day(s) ago"

def __init__(
self, can_generate_candidates: bool, reason: str, days_till_fail: int
Expand Down
4 changes: 2 additions & 2 deletions ax/analysis/healthcheck/tests/test_can_generate_candidates.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ def test_warns_if_a_trial_was_recently_run(self) -> None:
card.subtitle,
(
f"{CanGenerateCandidatesAnalysis.REASON_PREFIX}"
"The data is borked.\n"
"The data is borked.\n\n"
"LAST TRIAL RUN: 1 day(s) ago"
),
)
Expand Down Expand Up @@ -128,7 +128,7 @@ def test_is_fail_if_no_trial_was_recently_run(self) -> None:
card.subtitle,
(
f"{CanGenerateCandidatesAnalysis.REASON_PREFIX}"
"The data is old.\n"
"The data is old.\n\n"
"LAST TRIAL RUN: 3 day(s) ago"
),
)
Expand Down

0 comments on commit 5e115f8

Please sign in to comment.