Extract ui #248
Closed
Extract ui #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We'll hold off on this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shares should be tested before merging this.
This PR extracts the UI into a separate package (hosted at
@facadecompany/ignition-uion npm), so the UI can be used by other error notifiers.TODO: Remove the JS test from this repo's GitHub Actions, and move them to the
ignition-uirepo.@mpociot @freekmurze please check the following:
I changed this line:
ignition/src/Http/Controllers/ShareReportController.php
Line 14 in e3c6305
and the
ignition-uipackage now also doesn't send the report as a string, but as an object. I don't know why this was implemented originally, but it doesn't seem to be causing any issues now. Do you think this could be a problem?Read here for more information on why I did this: facade/ignition-js#13