Fix bug where uninitialized property within a job could break Ignition

facade · Dec 27, 2021 · d1dbc5e · d1dbc5e
1 parent a394a1f
commit d1dbc5e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/JobRecorder/JobRecorder.php b/src/JobRecorder/JobRecorder.php
@@ -3,13 +3,15 @@
 namespace Facade\Ignition\JobRecorder;
 
 use DateTime;
+use Error;
 use Exception;
 use Illuminate\Contracts\Encryption\Encrypter;
 use Illuminate\Contracts\Foundation\Application;
 use Illuminate\Contracts\Queue\Job;
 use Illuminate\Queue\CallQueuedClosure;
 use Illuminate\Queue\Events\JobExceptionOccurred;
 use Illuminate\Queue\Jobs\RedisJob;
+use Illuminate\Support\Collection;
 use Illuminate\Support\Str;
 use ReflectionClass;
 use ReflectionProperty;
@@ -115,9 +117,13 @@ protected function resolveCommandProperties(object $command, int $maxChainDepth)
                 return in_array($property->name, $propertiesToIgnore);
             })
             ->mapWithKeys(function (ReflectionProperty $property) use ($command) {
-                $property->setAccessible(true);
+                try{
+                    $property->setAccessible(true);
 
-                return [$property->name => $property->getValue($command)];
+                    return [$property->name => $property->getValue($command)];
+                }catch(Error $error) {
+                    return [$property->name => 'uninitialized'];
+                }
             });
 
         if ($properties->has('chained')) {

diff --git a/tests/stubs/jobs/QueueableJob.php b/tests/stubs/jobs/QueueableJob.php
@@ -20,6 +20,8 @@ class QueueableJob implements ShouldQueue
     /** @var array */
     private $property;
 
+    private string $uninitializedProperty;
+
     public function __construct(
         array $property,
         ?CarbonImmutable $retryUntilValue = null,