notice if dots have been used in the view name (#457)

* notice if dots have been used in the view name * a test for the case we have dots in the view name
facade · Jun 30, 2022 · 6acd82e · 6acd82e
1 parent 67bd545
commit 6acd82e
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 0 deletions.
diff --git a/src/SolutionProviders/ViewNotFoundSolutionProvider.php b/src/SolutionProviders/ViewNotFoundSolutionProvider.php
@@ -34,6 +34,13 @@ public function getSolutions(Throwable $throwable): array
 
         $suggestedView = $this->findRelatedView($missingView);
 
+        if ($suggestedView == $missingView) {
+            return [
+                BaseSolution::create("{$missingView} was not found.")
+                    ->setSolutionDescription('View names should not contain the . character!'),
+            ];
+        }
+
         if ($suggestedView) {
             return [
                 BaseSolution::create("{$missingView} was not found.")

diff --git a/tests/Solutions/ViewNotFoundSolutionProviderTest.php b/tests/Solutions/ViewNotFoundSolutionProviderTest.php
@@ -34,6 +34,15 @@ public function it_can_recommend_changing_a_typo_in_the_view_name()
         $this->assertTrue(Str::contains($solution->getSolutionDescription(), 'Did you mean `php-exception`?'));
     }
 
+    /** @test */
+    public function it_can_notice_if_the_view_name_contains_dots()
+    {
+        /** @var \Facade\IgnitionContracts\Solution $solution */
+        $solution = app(ViewNotFoundSolutionProvider::class)->getSolutions($this->getViewNotFoundException('foo.bar'))[0];
+
+        $this->assertTrue(Str::contains($solution->getSolutionDescription(), 'the . character'));
+    }
+
     /** @test */
     public function it_wont_recommend_another_controller_class_if_the_names_are_too_different()
     {

diff --git a/tests/stubs/views/foo.bar.blade.php b/tests/stubs/views/foo.bar.blade.php
@@ -0,0 +1 @@
+<h1>This is a blade view</h1>