Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Next Actions & Allow Their Immediate Selection #95

Merged
merged 8 commits into from
Dec 17, 2024

Conversation

JasonWarrenUK
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Styling
  • Build
  • Chore

Description

  • Allows creation of Next Actions within each unmet Need
  • Displays them instantly and allows their selection

    Uses a smoother logic than the similar add category feature in the toolkit

Note for @jackcasstlesjones

Look at screenshot 2. CHOOSE A RULE. It's time.

Screenshots

image

image

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Semantic HTML implemented?
  • Checked with axe DevTools and addressed Critical and Serious issues?
  • Color contrast tested?

Added/updated tests?

Please aim to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: It's the same component I couldn't write tests for before
  • I need help with writing tests

Delete branch after merge?

  • Yes
  • No

What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for thingswedo ready!

Name Link
🔨 Latest commit 2a30ce8
🔍 Latest deploy log https://app.netlify.com/sites/thingswedo/deploys/676181fbb39f2100080a9e9c
😎 Deploy Preview https://deploy-preview-95--thingswedo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@maxitect maxitect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot select existing tags when adding a tool anymore

Co-authored-by: Maxime Downe <[email protected]>
@JasonWarrenUK
Copy link
Collaborator Author

Cannot select existing tags when adding a tool anymore

That didn't happen on my branch, my edits on that file are purely whitespace and formatting

@jackcasstlesjones
Copy link
Collaborator

That didn't happen on my branch, my edits on that file are purely whitespace and formatting

it's not happening in main - did you change anything in the backend that could influence it?

Copy link
Collaborator

@maxitect maxitect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grrrrrreat!

@maxitect maxitect merged commit 5627786 into main Dec 17, 2024
5 checks passed
@maxitect maxitect deleted the feature/create-and-delete-actions branch December 17, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants