-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create header, categoryBar, and categoryButton components #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest a few minor changes and discussion points
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry a few more changes, I think there are a few instances of redundant comments, I've marked them up and you can commit them directly from github if you agree. Also there is a merge conflict that needs to be resolved, as soon as those are all addressed I can approve and merge! :)
delete all redundant comments and delete 'const CategoryBar: React.FC' Co-authored-by: Maxime Downe <[email protected]>
What type of PR is this? (check all applicable)
Description
1. Header Component
Header
component with:<h1>
) and a question mark button on the left (reserved for future functionality).ImageComponent
into theHeader
.next/image
API.fill
behavior.2. Styling Improvements
3. Create and then Delete CategoryButton Component
4. CategoryBar Component
CategoryBar
component that uses theButton
component to render a list of category buttons dynamically and now they can be chosen5. Global CSS Updates
header
class inglobal.css
with:background
: Defines the header background styling.border-bottom
: Adds a bottom border to the header for visual separation.6. Create ImageComponent:
next/image
API:objectFit
withstyle={{ objectFit: 'cover' }}
.sizes
prop to enhance image loading efficiency.rounded
prop.Screenshots
UI accessibility checklist
If your PR includes UI changes, please utilize this checklist:
Critical
andSerious
issues?Added/updated tests?
Please aim to keep the code coverage percentage at 80% and above.
What gif best describes this PR or how it makes you feel?