Handle the case if not able to spin slave pod #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR will handle the case if it is not able to spin a slave pod Now it will through a nice message to user Fixes openshiftio/openshift.io#3797
piyush-garg
changed the title
sthaha
reviewed
Oct 11, 2018
| @@ -13,12 +13,21 @@ def call(Map args = [:], body = null) { | |||
| jnlpTemplate() | |||
| ], | |||
| volumes: volumes(), | |||
| slaveConnectTimeout: 1, | |||
There was a problem hiding this comment.
@piyush-garg is this a wip pr?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will handle the case if it is not able to spin a slave pod
Now it will through a nice message to user
Fixes openshiftio/openshift.io#3797