Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish pepper the fixed JMX exporter quoted property values #204

Merged
merged 1 commit into from
Nov 29, 2018

Conversation

vorburger
Copy link
Collaborator

No description provided.

@vorburger
Copy link
Collaborator Author

@alexkieling I just noticed that your #194 was incomplete (I should have noticed this during review, or we should automate it, see #120) ... you had fixed up java/blocks/jmxexporter/fp-files/prometheus-config.yml and karaf/blocks/jmxexporter/fp-files/prometheus-config.yml but did not re-run fish-pepper, in both java/ and karaf/ and check those generated files in... this PR remedies that. Hope this makes sense and OK for you if I merge this?

@rhuss FYI

@abkieling
Copy link
Contributor

@vorburger I was having issues running fish-pepper and @rhuss told me I could submit the changes to those files and he (or somebody else) would run fish-pepper. By the way, how did you run fish-pepper so I know what to do next time?

@vorburger
Copy link
Collaborator Author

was having issues running fish-pepper

That was #13 right? I "interpreted" that you were fine after that.

By the way, how did you run fish-pepper so I know what to do next time?

like this:

cd java/ ; fish-pepper; cd ../karaf; fish-pepper

that's all there is to it! 😸

@vorburger vorburger merged commit c669138 into fabric8io-images:master Nov 29, 2018
@abkieling
Copy link
Contributor

@vorburger Would add those commands to a build.sh file make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants