Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing packages for UI builds #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pranavgore09
Copy link

This builder image is being used inside fabric8-planner builds.
Jenkins file https://github.com/fabric8-ui/fabric8-planner/blob/master/Jenkinsfile#L14 --> groovy script https://github.com/fabric8io/fabric8-pipeline-library/blob/master/vars/fabric8UITemplate.groovy#L9 --> https://hub.docker.com/r/fabric8/fabric8-ui-builder/tags/

and fabric8-planner builds are showing an error on console e.g> https://jenkins.cd.test.fabric8.io/job/fabric8-ui/job/fabric8-planner/job/master/129/consoleFull

make: Entering directory `/home/jenkins/workspace/8-ui_fabric8-planner_master-ZPP4IZOIOGZC2EHZQQ2O5PEN76546POVNRCE6JLDNBSQQFFN5RDA@2/node_modules/integer/build'
  CXX(target) Release/obj.target/integer/src/integer.o
make: g++: Command not found
make: *** [Release/obj.target/integer/src/integer.o] Error 127
make: Leaving directory `/home/jenkins/workspace/8-ui_fabric8-planner_master-ZPP4IZOIOGZC2EHZQQ2O5PEN76546POVNRCE6JLDNBSQQFFN5RDA@2/node_modules/integer/build'
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2

So I feel that we are missing few packages and need to install them.
Following are packages we need to run the build smoothly

  • groupinstall 'Development Tools'
  • gcc-c++"

Ref:
facebook/react#3744 (comment)
https://unix.stackexchange.com/a/32439

Once merged I hope to see the changes in fabric8-cd whenever I use container('ui') in my Jenkins file

This builder image is being used inside fabric8-planner builds.
Jenkins file https://github.com/fabric8-ui/fabric8-planner/blob/master/Jenkinsfile#L14 --> groovy script https://github.com/fabric8io/fabric8-pipeline-library/blob/master/vars/fabric8UITemplate.groovy#L9 --> https://hub.docker.com/r/fabric8/fabric8-ui-builder/tags/

and fabric8-planner builds are showing an error on console 
```
make: Entering directory `/home/jenkins/workspace/8-ui_fabric8-planner_master-ZPP4IZOIOGZC2EHZQQ2O5PEN76546POVNRCE6JLDNBSQQFFN5RDA@2/node_modules/integer/build'
  CXX(target) Release/obj.target/integer/src/integer.o
make: g++: Command not found
make: *** [Release/obj.target/integer/src/integer.o] Error 127
make: Leaving directory `/home/jenkins/workspace/8-ui_fabric8-planner_master-ZPP4IZOIOGZC2EHZQQ2O5PEN76546POVNRCE6JLDNBSQQFFN5RDA@2/node_modules/integer/build'
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
```
So I feel that we are missing few packages and need to install them. 
Following are packages we need to run the build smoothly
 - groupinstall 'Development Tools'
 - gcc-c++"

Ref:
facebook/react#3744 (comment)
https://unix.stackexchange.com/a/32439

Once merged I hope to see the changes in fabric8-cd whenever I use `container('ui')` in my Jenkins file
@fabric8cd
Copy link

snapshot fabric8-ui-builder image is available for testing. docker pull fabric8/fabric8-ui-builder:SNAPSHOT-PR-6-1

@pranavgore09
Copy link
Author

before the merge, I would like to use this snapshot first! :)

@rupalibehera
Copy link

@pranavgore09 , you can fork this library https://github.com/fabric8io/fabric8-pipeline-library/blob/master/vars/fabric8UITemplate.groovy#L9 and make change the image to this "fabric8/fabric8-ui-builder:SNAPSHOT-PR-6-1" and then raise a PR here https://github.com/fabric8-ui/fabric8-planner changing https://github.com/fabric8-ui/fabric8-planner/blob/master/Jenkinsfile#L1 to your fork and branch for eg: github.com/pranavgore09/fabric8-pipeline-library@test-branch, in the CI pipeline we can check if it is going well.

@pranavgore09
Copy link
Author

yes @rupalibehera doing the same!

@joshuawilson
Copy link
Collaborator

please validate the other UI builds before you merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants