fix(launcher): retry /git/user api call on fail #3520
Conversation
Ike Plugins (test-keeper)Thank you @vikram-raj for this contribution!
It appears that no tests have been added or updated in this PR. Automated tests give us confidence in shipping reliable software. Please add some as part of this change. If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command For more information please head over to official documentation. You can find there how to configure the plugin. |
|
The E2E smoke test with feature level set to 'released' failed. Please review the job results and re-run the job by commenting [e2e-test-released] if necessary. |
|
The E2E smoke test with feature level set to 'beta' failed. Please review the job results and re-run the job by commenting [e2e-test-beta] if necessary. |
|
[e2e-test-beta] |
|
The E2E smoke test with feature level set to 'released' failed. Please review the job results and re-run the job by commenting [e2e-test-released] if necessary. |
|
The E2E smoke test with feature level set to 'beta' failed. Please review the job results and re-run the job by commenting [e2e-test-beta] if necessary. |
|
The E2E smoke test with feature level set to 'released' failed. Please review the job results and re-run the job by commenting [e2e-test-released] if necessary. |
|
The E2E smoke test with feature level set to 'beta' failed. Please review the job results and re-run the job by commenting [e2e-test-beta] if necessary. |
| @@ -87,28 +88,23 @@ export class AppLauncherGitproviderService implements GitProviderService { | |||
| if (user && user.login) { | |||
| this.gitHubUserLogin = user.login; | |||
| const orgs: { [name: string]: string } = {}; | |||
| return this.getUserOrgs(user.login).pipe( | |||
There was a problem hiding this comment.
Did you mean to remove this call? Will the user object always have the data we need?
There was a problem hiding this comment.
Yes, this API /api/services/git/user already return the GitHub organizations of the user. We use this API call to check if user git account is connected or not and if connected it returns all data that we need to show on the UI.
|
[e2e-test-beta] |
|
The E2E smoke test with feature level set to 'released' failed. Please review the job results and re-run the job by commenting [e2e-test-released] if necessary. |
|
The E2E smoke test with feature level set to 'beta' failed. Please review the job results and re-run the job by commenting [e2e-test-beta] if necessary. |
|
/ok-without-tests |
|
🎉 This PR is included in version 5.2.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Issue - openshiftio/openshift.io#4743