Skip to content
This repository has been archived by the owner on Jul 23, 2019. It is now read-only.

fix: add a loader in gitHubProvider component while github detail fet… #569

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

vikram-raj
Copy link
Collaborator

…ch in background

  • Add a loader to gitHubProvider component while user gitHub detail is being load.
  • Handle error for gitHubDetail service call.

Related issue - openshiftio/openshift.io#4743

@ghost ghost assigned vikram-raj Feb 5, 2019
@ghost ghost added the in progress label Feb 5, 2019
@vikram-raj
Copy link
Collaborator Author

@edewit Please have a look.

Copy link
Member

@edewit edewit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@edewit edewit merged commit 9e3efda into fabric8-launcher:master Feb 5, 2019
@ghost ghost removed the in progress label Feb 5, 2019
@fabric8cd
Copy link

🎉 This PR is included in version 3.4.22 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants