This repository has been archived by the owner on May 29, 2020. It is now read-only.
Ui/new ride ui #45
Open
Ui/new ride ui #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 10, 2020 13:35
- Created history page - Set API calls and logic on client side only
- Redirecting to break/inactive/active depending on steps number and workStatus - Handling mutual rides mutations in steps - Handling cancel ride from dashboard - Added ride history for current day - New UI for Account page, closer to new overall UI
Scttpr
force-pushed
the
ui/new-ride-ui
branch
from
ad77fe3 to
8ea583c
Compare
# Conflicts: # CHANGELOG.md # pages/_campus/index.vue # plugins/socket.js
Nainterceptor
suggested changes
May 5, 2020
Comment on lines
+9
to
+11
| export default { | ||
|
|
||
| }; |
There was a problem hiding this comment.
useless export here
Comment on lines
6
to
10
| <script> | ||
| import sidemenuMenu from '~/components/sidemenu-menu.vue'; | ||
|
|
||
| export default { | ||
| components: { sidemenuMenu }, | ||
|
|
||
| }; | ||
| </script> |
There was a problem hiding this comment.
this export become useless
| @@ -0,0 +1,17 @@ | |||
| <svg | |||
There was a problem hiding this comment.
Is it possible to get icon like this but in fontawesome ?
| @@ -0,0 +1,31 @@ | |||
| <svg | |||
There was a problem hiding this comment.
Is it possible to get icon like this but in fontawesome ?
| @@ -0,0 +1,25 @@ | |||
| <svg | |||
There was a problem hiding this comment.
Is it possible to get icon like this but in fontawesome ?
| @@ -0,0 +1,21 @@ | |||
| <svg | |||
There was a problem hiding this comment.
Is it possible to get icon like this but in fontawesome ?
| @@ -17,6 +17,10 @@ export const mutations = { | |||
|
|
|||
| export const getters = { | |||
| hasCampus: (s) => s.campus !== null, | |||
| globalCampus(s, g, rs, rg) { | |||
| // eslint-disable-next-line no-unused-expressions | |||
| rg.campus; | |||
There was a problem hiding this comment.
Mhhh ? eslint seems right here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist