Add NoReflectionAttribute #2861
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #2710 (comment).
Given
I get
with comments denoting changes with the attribute. There's also a warning
warning FABLE: QuickTest.U is annotated with NoReflectionAttribute, but is being used in types which support reflection. This may lead to runtime errors.
becauseR
usesU
, but does not itself have the attribute.@alfonsogarciacaro, if you think this is a good addition, I can add tests and try to figure out #2710 (comment).
One thing that worries me is that
Union.name()
refers to the case names, and it's used both intoString
andtoJSON
.PerhapsFor these cases we could have a different base union class in TS that would just use the tag instead of case name. No specialized classes for unions with no reflection would then be needed to be emitted at all.NoReflection
could also imply that default stringification/serialization is for all intents and purposes not supported?