Skip to content

Commit

Permalink
Bump version to 2.0.7
Browse files Browse the repository at this point in the history
  • Loading branch information
alfonsogarciacaro committed Oct 27, 2018
1 parent e276b90 commit 1b4f084
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 7 deletions.
5 changes: 3 additions & 2 deletions build.fsx
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ let installDotnetSdk () =
run CWD dotnetExePath "--version"

let clean () =
!! "build" ++ "**/.fable"
!! "build" ++ "**/.fable" ++ "src/**/obj"
|> CleanDirs

let nugetRestore dir =
Expand Down Expand Up @@ -339,7 +339,8 @@ Target "BuildReplAsNodeApp" (fun () ->
runBench2 ()
)

"PublishPackages"
"Clean"
==> "PublishPackages"
==> "GitHubRelease"

// Start build
Expand Down
2 changes: 1 addition & 1 deletion src/dotnet/Fable.Compiler/CLI/Agent.fs
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ let tryGetOption name (opts: IDictionary<string, string>) =
let checkFableCoreVersion (checkedProject: FSharpCheckProjectResults) =
for ref in checkedProject.ProjectContext.GetReferencedAssemblies() do
if ref.SimpleName = "Fable.Core" then
let version = System.Text.RegularExpressions.Regex.Match(ref.QualifiedName, @"Version=(\d+\.\d+\.\d+)")
let version = System.Text.RegularExpressions.Regex.Match(ref.QualifiedName, @"Version=(\d+\.\d+)\.\d+")
if version.Groups.[1].Value <> Literals.CORE_VERSION then

This comment has been minimized.

Copy link
@AkosLukacs

AkosLukacs Oct 27, 2018

This compares the current major.minor version against the full major.minor.patch version in Literals.CORE_VERSION. And you get something like this Error: Fable.Core v2.0 detected, expecting v2.0.1

failwithf "Fable.Core v%s detected, expecting v%s" version.Groups.[1].Value Literals.CORE_VERSION
// else printfn "Fable.Core version matches"
Expand Down
4 changes: 2 additions & 2 deletions src/dotnet/Fable.Compiler/CLI/CLI.Util.fs
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ namespace Fable.CLI

module Literals =

let [<Literal>] VERSION = "2.0.6"
let [<Literal>] CORE_VERSION = "2.0.0"
let [<Literal>] VERSION = "2.0.7"
let [<Literal>] CORE_VERSION = "2.0.1"
let [<Literal>] DEFAULT_PORT = 61225
let [<Literal>] FORCE = "force:"

Expand Down
4 changes: 2 additions & 2 deletions src/dotnet/Fable.Compiler/Fable.Compiler.fsproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<Description>Fable: F# to JS Compiler</Description>
<Version>2.0.6</Version>
<PackageVersion>2.0.6</PackageVersion>
<Version>2.0.7</Version>
<PackageVersion>2.0.7</PackageVersion>
<OutputType>Exe</OutputType>
<PackageType>DotnetCliTool</PackageType>
<AssemblyName>dotnet-fable</AssemblyName>
Expand Down
7 changes: 7 additions & 0 deletions src/dotnet/Fable.Compiler/RELEASE_NOTES.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
### 2.0.7

* Implement eprintf and eprintfn @inosik
* Fix #1389: Throw proper error when match cases are incomplete @Zaid-Aja
* Fix #1602: constructor "as this" notation
* Only check for Fable.Core major and minor version

### 2.0.6

* Don't change the first letter of erased union cases in keyValueList
Expand Down

0 comments on commit 1b4f084

Please sign in to comment.