-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monolith final #387
base: master
Are you sure you want to change the base?
Monolith final #387
Conversation
git status
Add the uptimerobot logo to the footer! |
GeneralNavigationAll links on the navbar should open on a new tab (except HOME). I'd remove the "Smart Citizen" from here, as it doesn't link anywhere: Could the title of the section go near the logo? It's useful to have this navigation, but I feel it can get very long. Maybe can be reduced or only show the "important" item on the top, and a couple of items after that below if needed? (worth discussing) A new option could be:
instead of: Banner areaMake banner area less "black". I feel there is too much "overpowering" presence of the top banner area on the top (user/kit/experiment): As a reference, in dashboard.smartcitizen.me, there is no navbar, which I think in the monolith should be kept, but that we can leave as the only part that is black. The lower part could be simply white (?) ButtonsTransitions on buttons (for fading from one color to another) on hover. Also I'd use some other colors from the palette, like blue or yellow: Danger areasI would differentiate "Other actions" with a background in red (as a danger area): |
ExperimentsExperiment pageI love this one! I think this can have (in the future) more insights of the experiments. For now maybe something like: "4 kits out of 5 active on ". In the future, maybe other metrics can be added, or even the health-metrics once we have them. Also add online/offline for each kit? Similar to the kit, I would only say "Edit Experiment". I would however change the "readings" section for "data": In the future, we could also add an option for "download data on this experiment" button, to group all the downloads from one single experiment. CreateOverall, we need a bit more guidance on what an experiment is and what does each choice means... What is an experiment?Creating an experiment could have more verbose explanation of what an experiment is, maybe as a popup/modal or something? What is an experiment? DatesMore explanation could be added on what those dates imply. At the moment is just "semantic". Probably we need to rethink a bit what dates mean for experiments as they can be left blank. Adding kitsOn my case, kits dropdown look very linuxy, but I think search could be improved (adding not just the name, but a location, an user, description, and things like that). Multiple selection would be an important feature. Maybe a future feature, but an easier way to filter kits would be great here and on the search, or in the kits page of a certain user: |
First release candidate of the Monolith v1 project! Includes user, device and experiment management, implemented in the rails app.
@pral2a @oscgonfer please review at https://staging-api.smartcitizen.me/ui/, and add any snags here as comments (with screenshots / browser info if applicable). Bear in mind that readings data is patchy on staging, so the graphs might look a little funny.
Important: we have a new
deploy.sh
script which handles building all the client side assets as well as the usual deployment business. Remember to use this!