Adding LRU cache to make Range lookups much faster #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludu12
commented
Sep 15, 2024
Comment on lines
+787
to
+788
| cache = require('../src/Range.js').cache; | ||
| cache.clear(); |
There was a problem hiding this comment.
Cache needs to be cleared for this test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that one of our models was performing poorly due to the compute going on in
Range.js. This model is mostly made up of large vlookup tables and so everytime we had to lookup a value, we had to recreate the 2d matrix that made up the table. This was being done hundreds of times within the same "recalculation".This PR adds a cache in front of this calculation so that these tables are created once.
I've added a script along with a dumbed down version of our model to show case the improvement:
Before:
After: