feat: add vietnam language #951
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ThomasBui <[email protected]>
thinhbg2812-2
force-pushed
the
vn-language
branch
3 times, most recently
from
90d4985 to
0547fb7
Compare
Signed-off-by: ThomasBui <[email protected]>
thinhbg2812-2
force-pushed
the
vn-language
branch
from
0547fb7 to
dec886a
Compare
|
Will @hongky-1994 review your translations? |
hongky-1994
suggested changes
Dec 4, 2024
Update translation Co-authored-by: Ky_pham <[email protected]>
Update translation Co-authored-by: Ky_pham <[email protected]>
Update translation Co-authored-by: Ky_pham <[email protected]>
Update translation Co-authored-by: Ky_pham <[email protected]>
Update translation Co-authored-by: Ky_pham <[email protected]>
Update translation Co-authored-by: Ky_pham <[email protected]>
Update translation Co-authored-by: Ky_pham <[email protected]>
Update translation Co-authored-by: Ky_pham <[email protected]>
Update translation Co-authored-by: Ky_pham <[email protected]>
Update translation Co-authored-by: Ky_pham <[email protected]>
Update translation Co-authored-by: Ky_pham <[email protected]>
|
Is this ready to be merged, or should another native speaker do a final review? |
|
I think it's ready; i asked him pretty much about the naming and context, and he has high credit in team xD |
|
Ok. Thank you! I will review and merge it later this month. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Vietnamese for @valibot/i18n
Here my brother: @hongky-1994