[run] images, tag, role and exclusive env/scecret #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabfuel
reviewed
Feb 26, 2019
|
|
||
| if diff: | ||
| print_diff(td, 'Using task definition: %s' % task) | ||
|
|
||
| if image or tag or role: | ||
| td = create_task_definition(action, td) |
There was a problem hiding this comment.
If you create a new task definition here, I think it should be deregistered, after the task had been successfully executed. Otherwise you end up with n active task definitions in ECS. What do you think? As in the deploy action, this could be controllable via a cli parameter
Maks3w
force-pushed
the
override-run
branch
3 times, most recently
from
3acf716
to
dcc3fa7
Compare
Maks3w
force-pushed
the
override-run
branch
from
dcc3fa7
to
f9b53e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mimics the flags available on deploy also for run