Drop support for Python 3.8 and Python 3.9

Supported versions are:
* Python 3.10
* Python 3.11

Update all tools that were stuck on older versions
because the tools themselves dropped Python 3.8 (and 3.9).

Format and remove lint according to newest tool versions.

GitHub: fix mxcube#1046

.github/workflows/pages.yaml

@@ -25,10 +25,10 @@ jobs:
           # See "Caveats" at https://pypi.org/project/sphinx-last-updated-by-git
           fetch-depth: 0
 
-      - name: "Set up Python 3.8"
+      - name: "Set up Python 3.10"
         uses: "actions/setup-python@v5"
         with:
-          python-version: "3.8"
+          python-version: "3.10"
 
       - name: "Install OpenLDAP's dev package with apt"
         run: |

.github/workflows/pre-commit.yml

@@ -14,10 +14,10 @@ jobs:
 
       - uses: actions/checkout@v3
 
-      - name: Set up Python 3.8
+      - name: Set up Python 3.10
         uses: actions/setup-python@v4
         with:
-          python-version: "3.8"
+          python-version: "3.10"
 
       - name: Install openldap
         # yamllint disable rule:line-length

.github/workflows/tests.yml

@@ -13,7 +13,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: ["3.8", "3.9", "3.10", "3.11"]
+        python-version: ["3.10", "3.11"]
     steps:
       - uses: actions/checkout@v3
 
@@ -30,7 +30,7 @@ jobs:
         run: |
           python -m pip install --upgrade pip
           python -m pip install poetry --user
-          python -m poetry install --extras=tango
+          python -m poetry install
 
       - name: Test with pytest
         run: |

.isort.cfg

@@ -1,4 +1,4 @@
 [settings]
 profile=black
-py_version=38
+py_version=310
 force_grid_wrap=2

.pre-commit-config.yaml

@@ -10,11 +10,11 @@ repos:
           - --strict
 
   - repo: https://github.com/python-poetry/poetry
-    rev: 1.8.0
+    rev: 2.0.1
     hooks:
       - id: poetry-check
 
-  - repo: https://github.com/myint/autoflake
+  - repo: https://github.com/PyCQA/autoflake
     rev: v2.3.1
     hooks:
       - id: autoflake
@@ -27,20 +27,18 @@ repos:
           - --ignore-pass-after-docstring
 
   - repo: https://github.com/pycqa/isort
-    rev: 5.13.2
+    rev: 6.0.0
     hooks:
       - id: isort
 
-  - repo: https://github.com/psf/black
-    rev: 24.8.0  # The following version (`24.10.0`) dropped support for Python 3.8.
+  - repo: https://github.com/psf/black-pre-commit-mirror
+    rev: 25.1.0
     hooks:
       - id: black
         name: Black
 
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.6.0
-    # The following version (pre-commit-hooks 5.0.0) requires pre-commit 3.2.0
-    # which does not support Python 3.8 (dropped in pre-commit 3.0.0).
+    rev: v5.0.0
     hooks:
       - id: trailing-whitespace
         # Exclude files from trailing-whitespace checks until we get around fixing them.

conda-environment-dev.yml

@@ -1,6 +1,7 @@
 %YAML 1.2
 ---
 
+
 name: mxcubecore
 
 channels:
@@ -11,7 +12,7 @@ dependencies:
   # Runtime dependencies
   # ====================
 
-  - python >=3.8,<3.12
+  - python >=3.10,<3.12  # Keep in sync with `pyproject.toml`
 
   # `openldap` is necessary for `python-ldap` but can not be installed by pip or Poetry.
   # Note also that on PyPI `python-ldap` is only available as *sdist*, not as *wheel*,
@@ -26,4 +27,7 @@ dependencies:
   # Development dependencies
   # ========================
 
-  - poetry
+  - poetry ==2.0.1  # Keep in sync with `.pre-commit-config.yaml` and `poetry.lock`
+
+
+...

deprecated/HardwareObjects/TacoDevice_MTSafe.py

@@ -454,7 +454,7 @@ def dev_io(mdevname, mdevcommand, *parin, **kw):
                     io_out,
                     0,
                     parin,
-                    **kw
+                    **kw,
                 )
             except Exception:
                 raise Dev_Exception(

deprecated/HardwareObjects/mockup/CameraMockup.py

@@ -1,5 +1,4 @@
-"""Class for cameras connected to framegrabbers run by Taco Device Servers
-"""
+"""Class for cameras connected to framegrabbers run by Taco Device Servers"""
 
 import logging
 import os

mxcubecore/Command/Exporter.py

@@ -18,7 +18,7 @@
 #  You should have received a copy of the GNU General Lesser Public License
 #  along with MXCuBE. If not, see <http://www.gnu.org/licenses/>.
 
-"""Exporter, ExporterChannel and ExporterCommand implementation """
+"""Exporter, ExporterChannel and ExporterCommand implementation"""
 
 # from warnings import warn
 import logging
@@ -231,7 +231,7 @@ def __init__(
         address=None,
         port=None,
         timeout=3,
-        **kwargs
+        **kwargs,
     ):
         ChannelObject.__init__(self, name, username, **kwargs)
 

mxcubecore/Command/Pool.py

@@ -165,7 +165,7 @@ def __init__(
         username=None,
         polling=None,
         timeout=10000,
-        **kwargs
+        **kwargs,
     ):
         ChannelObject.__init__(self, name, username, **kwargs)
 

mxcubecore/Command/Sardana.py

@@ -19,7 +19,7 @@
 #  along with MXCuBE. If not, see <http://www.gnu.org/licenses/>.
 
 
-"""Sardana Control System  """
+"""Sardana Control System"""
 
 from __future__ import absolute_import
 

mxcubecore/Command/Spec.py

@@ -95,7 +95,7 @@ def __init__(
         version=None,
         username=None,
         dispatchMode=SpecVariable.FIREEVENT,
-        **kwargs
+        **kwargs,
     ):
         ChannelObject.__init__(self, name, username, **kwargs)
         SpecVariableA.__init__(self, varname, version, dispatchMode)

mxcubecore/Command/Taco.py

@@ -161,7 +161,7 @@ def __init__(
         username=None,
         polling=None,
         args=None,
-        **kwargs
+        **kwargs,
     ):
         ChannelObject.__init__(self, name, username, **kwargs)
 

mxcubecore/Command/Tine.py

@@ -48,7 +48,7 @@ def __init__(
         username=None,
         ListArgs=None,
         timeout=1000,
-        **kwargs
+        **kwargs,
     ):
         CommandObject.__init__(self, name, username, **kwargs)
         self.commandName = command_name

mxcubecore/Command/exporter/StandardClient.py

@@ -18,7 +18,7 @@
 #  You should have received a copy of the GNU General Lesser Public License
 #  along with MXCuBE. If not, see <http://www.gnu.org/licenses/>.
 
-""" ProtocolError and StandardClient implementation"""
+"""ProtocolError and StandardClient implementation"""
 import socket
 import sys
 

mxcubecore/HardwareObjects/BeamlineTools.py

@@ -17,8 +17,7 @@
 #  You should have received a copy of the GNU Lesser General Public License
 #  along with MXCuBE. If not, see <http://www.gnu.org/licenses/>.
 
-"""
-"""
+""" """
 
 from mxcubecore.BaseHardwareObjects import HardwareObject
 

mxcubecore/HardwareObjects/BlissShutter.py

@@ -18,7 +18,7 @@
 #  You should have received a copy of the GNU Lesser General Public License
 #  along with MXCuBE. If not, see <http://www.gnu.org/licenses/>.
 
-""" BlissShutter class - interface for shutter controlled by BLISS
+"""BlissShutter class - interface for shutter controlled by BLISS
 Implements _set_value, get_value methods
 Bliss states are: UNKNOWN, OPEN, CLOSED, FAULT
 "MOVING", "DISABLE", "STANDBY", "RUNNING"

mxcubecore/HardwareObjects/ESRF/ESRFBeamlineActions.py

@@ -15,7 +15,7 @@
 #
 #  You should have received a copy of the GNU General Lesser Public License
 #  along with MXCuBE.  If not, see <http://www.gnu.org/licenses/>.
-""" Execute commands and toggle two state actions
+"""Execute commands and toggle two state actions
 Example xml file:
 <object class = "ESRF.ESRFBeamlineActions">
   <object role="controller" href="/bliss"/>

mxcubecore/HardwareObjects/ESRF/ESRFMD2SC3.py

@@ -1,5 +1,4 @@
-"""ESRF SC3 Sample Changer Hardware Object
-"""
+"""ESRF SC3 Sample Changer Hardware Object"""
 
 import ESRF.ESRFSC3 as ESRFSC3
 import SC3

mxcubecore/HardwareObjects/ESRF/ESRFPhotonFlux.py

@@ -18,7 +18,7 @@
 #  You should have received a copy of the GNU General Lesser Public License
 #  along with MXCuBE. If not, see <http://www.gnu.org/licenses/>.
 
-""" Photon flux calculations
+"""Photon flux calculations
 Example xml_ configuration:
 
 .. code-block:: xml

mxcubecore/HardwareObjects/ESRF/ESRFSC3.py

@@ -1,5 +1,4 @@
-"""ESRF SC3 Sample Changer Hardware Object
-"""
+"""ESRF SC3 Sample Changer Hardware Object"""
 
 import functools
 import logging

mxcubecore/HardwareObjects/ESRF/ESRFSmallXrayCentring.py

@@ -15,8 +15,7 @@
 #
 # You should have received a copy of the GNU Lesser General Public License
 # along with MXCuBE.  If not, see <https://www.gnu.org/licenses/>.
-"""
-"""
+""" """
 
 from __future__ import (
     absolute_import,

mxcubecore/HardwareObjects/ESRF/ID30SC3.py

@@ -1,5 +1,4 @@
-"""ESRF SC3 Sample Changer Hardware Object
-"""
+"""ESRF SC3 Sample Changer Hardware Object"""
 
 import ESRFSC3
 import SC3

mxcubecore/HardwareObjects/ESRF/OxfordCryostream.py

@@ -18,7 +18,7 @@
 #  You should have received a copy of the GNU General Lesser Public License
 #  along with MXCuBE. If not, see <http://www.gnu.org/licenses/>.
 
-""" Oxford Cryostream, controlled by bliss.
+"""Oxford Cryostream, controlled by bliss.
 Example xml_ configuration:
 
 .. code-block:: xml

mxcubecore/HardwareObjects/ESRF/Transmission.py

@@ -17,7 +17,7 @@
 #
 #  You should have received a copy of the GNU General Lesser Public License
 #  along with MXCuBE. If not, see <http://www.gnu.org/licenses/>.
-"""Transmission with bliss """
+"""Transmission with bliss"""
 
 from mxcubecore.HardwareObjects.abstract.AbstractTransmission import (
     AbstractTransmission,

mxcubecore/HardwareObjects/Gphl/GphlMessages.py

@@ -1,6 +1,6 @@
 #! /usr/bin/env python
 # encoding: utf-8
-""" Abstract beamline interface message classes
+"""Abstract beamline interface message classes
 
 License:
 

mxcubecore/HardwareObjects/Gphl/GphlWorkflow.py

@@ -1757,7 +1757,7 @@ def setup_data_collection(self, payload, correlation_id):
             translation = GphlMessages.GoniostatTranslation(
                 rotation=newRotation,
                 requestedRotationId=sweepSetting.id_,
-                **translation_settings
+                **translation_settings,
             )
             self._latest_translation_id = translation.id_
             self._recentrings.append(translation)
@@ -2533,7 +2533,7 @@ def execute_sample_centring(
                 GphlMessages.GoniostatTranslation(
                     rotation=goniostatRotation,
                     requestedRotationId=requestedRotationId,
-                    **dd0
+                    **dd0,
                 ),
                 positionsDict,
             )
@@ -2624,7 +2624,7 @@ def handle_collection_start(
             )
             translation = GphlMessages.GoniostatTranslation(
                 requestedRotationId=scan.sweep.goniostatSweepSetting.id_,
-                **translation_settings
+                **translation_settings,
             )
             self._latest_translation_id = translation.id_
             self._scan_id_to_translation_id[scan.id_] = translation.id_

mxcubecore/HardwareObjects/Gphl/GphlWorkflowConnection.py

@@ -830,7 +830,7 @@ def _GoniostatRotation_to_python(self, py4jGoniostatRotation, isSweepSetting=Fal
             GphlMessages.GoniostatTranslation(
                 id_=uuid.UUID(translationUuidString),
                 rotation=result,
-                **translationAxisSettings
+                **translationAxisSettings,
             )
         return result
 

mxcubecore/HardwareObjects/GrobSampleChanger.py

@@ -1,5 +1,4 @@
-"""Sample Changer Hardware Object
-"""
+"""Sample Changer Hardware Object"""
 
 import logging