Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transport(ptp): move from protobuf to fixed-size c-struct #388

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

csegarragonz
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 66.82243% with 71 lines in your changes are missing coverage. Please review.

Project coverage is 81.59%. Comparing base (d9810b0) to head (8eb27e0).

Files Patch % Lines
src/transport/PointToPointBroker.cpp 70.07% 38 Missing ⚠️
src/mpi/MpiWorld.cpp 0.00% 18 Missing ⚠️
src/scheduler/Scheduler.cpp 53.84% 6 Missing ⚠️
src/transport/PointToPointServer.cpp 73.68% 5 Missing ⚠️
src/transport/PointToPointClient.cpp 69.23% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
+ Coverage   81.40%   81.59%   +0.18%     
==========================================
  Files         107      108       +1     
  Lines        7223     7281      +58     
==========================================
+ Hits         5880     5941      +61     
+ Misses       1343     1340       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

csegarragonz added a commit that referenced this pull request Feb 29, 2024
This commit moves the abstraction of a PTP message from a protobuf
object to a fixed-size C-struct with a heap pointer. The rationale
is that these PTP messages move through the system, and even when
careful it is challenging to keep track of the copies allocations
that protobuf is doing under the hood. In exchange, we are very
explicity about the copies and allocations we do.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant