Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component | Donut: Half Donut #509

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Component | Donut: Half Donut #509

merged 4 commits into from
Jan 29, 2025

Conversation

curran
Copy link

@curran curran commented Dec 13, 2024 •
edited
Loading

Adds support for half donut including:

  • Scaling to fit the geometry in the container
  • Applying label offsets automatically if centralLabelsOffsetY and centralLabelsOffsetX are not defined
image image image image

@curran curran marked this pull request as ready for review December 13, 2024 21:55
@curran curran mentioned this pull request Dec 13, 2024
Closed
@curran curran force-pushed the feature/half-donut branch from 9bfe908 to d612fcc Compare December 13, 2024 22:04
@rokotyan rokotyan force-pushed the feature/half-donut branch 2 times, most recently from 3bd65b2 to f32cbb8 Compare December 14, 2024 01:39
@reb-dev reb-dev self-requested a review January 17, 2025 19:39
@lee00678 lee00678 merged commit e75f896 into f5:main Jan 29, 2025
4 checks passed
@curran
Copy link
Author

curran commented Feb 1, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lee00678 lee00678 lee00678 approved these changes

@reb-dev reb-dev Awaiting requested review from reb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@curran @lee00678 @rokotyan