Partial bitstream support #1492
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmichalak
force-pushed
the
partial-bitstream-support
branch
from
47d9482 to
1754cf0
Compare
litghost
reviewed
Nov 10, 2020
| // Creates the configuration package for partial configuration | ||
| // which is later on used by the bitstream writer to generate | ||
| // the partial bitstream file. | ||
| static void createPartialConfigurationPackage( |
There was a problem hiding this comment.
This comment is missing some important information. For example why is far_address even an argument if PacketData contains the far_address. Does this function work if PacketData spans multiple frames? If PacketData spans multiple frames, what is the right thing to do?
There was a problem hiding this comment.
There are some more changes I've pushed recently:
- I removed the
far_addressfrom arguments because we should handle the FAR addreses forCLB_IO_CLKblocks andBRAMsseparately, in the result we pass a map with data and address for them. This step is handled here and later we use this data to generate proper FAR/FDRI for each of these block types here. - I added a new definition of addMissingFrames function to handle address gaps in a partial reconfiguration region.
- To handle the PR region correctly
CLB_IO_CLKandBRAMaddress ranges should be defined as arguments toxc7frames2bit
added 2 commits
November 25, 2020 13:30
Signed-off-by: Jan Kowalewski <[email protected]>
Signed-off-by: Jan Kowalewski <[email protected]>
kowalewskijan
force-pushed
the
partial-bitstream-support
branch
from
1754cf0 to
24743ef
Compare
This was referenced Nov 26, 2020
kowalewskijan
force-pushed
the
partial-bitstream-support
branch
from
24743ef to
161e4f9
Compare
Signed-off-by: Jan Kowalewski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds partial bitstream generation support for Series7.