Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add shortcut to rotate camera by 90degrees #14 #1634

Merged
merged 12 commits into from
Sep 27, 2024

Conversation

dk1242
Copy link
Contributor

@dk1242 dk1242 commented Sep 25, 2024

I have added a shortcut for rotating the camera by +/-90 degrees.
Pressing the key "4" will rotate the camera by -90 degrees and "6" will rotate it by 90 degrees.

Fixes for #14

Copy link

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.85%. Comparing base (fe2e432) to head (f3781c4).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1634   +/-   ##
=======================================
  Coverage   96.84%   96.85%           
=======================================
  Files         108      108           
  Lines        7671     7683   +12     
=======================================
+ Hits         7429     7441   +12     
  Misses        242      242           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

library/public/camera.h Outdated Show resolved Hide resolved
Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks nice! Please also add doc for this feature in:

  • vtkF3DRenderer::ConfigureCheatSheet
  • doc/user/INTERACTIONS.md

doc/user/INTERACTIONS.md Outdated Show resolved Hide resolved
doc/user/INTERACTIONS.md Outdated Show resolved Hide resolved
@mwestphal mwestphal merged commit 095349c into f3d-app:master Sep 27, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants