Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quake MDL feature #1591

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Quake MDL feature #1591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
9d96975
Adding preliminary Quake1 MDL plugin.
malespiaut May 27, 2024
31e502a
Fixing some vector types error in vtkQuakeMDLReader.
malespiaut May 27, 2024
614385b
Fixing some formatting error (whitespaces) in vtkQuakeMDLReader.
malespiaut May 27, 2024
802a5ef
Fixing typo in vtkQuakeMDLReader.
malespiaut May 27, 2024
bccc126
Cleaning out unnecessary code.
malespiaut Jun 2, 2024
b294c6a
Add importer
Youva Aug 25, 2024
6f7832f
Removed hardcoded path
Youva Aug 25, 2024
803caa9
Fixed crash due to memory allocation on normals and interpolated fram…
Youva Sep 2, 2024
415e7a5
Fix for test on --scan-plugins leading to crash
Youva Sep 8, 2024
3fe48e9
Merge remote-tracking branch 'origin-f3d/master' into quake-mdl-fork.
Youva Sep 8, 2024
f390b60
Removed modification at line 255, engine.cxx
Youva Sep 8, 2024
18e2348
Formatting
Youva Sep 8, 2024
b4b49b4
Formatting
Youva Sep 8, 2024
7cc7e0c
Formatting
Youva Sep 8, 2024
845a0e6
Fixed build errors w/ strict_build
Youva Sep 24, 2024
2b9de40
Update vtkQuakeMDLImporter.cxx
Youva Sep 24, 2024
e22fe52
Update vtkQuakeMDLImporter.cxx
Youva Sep 24, 2024
71a6bda
Fixed override updateTimeStep.
Youva Sep 24, 2024
77f65ee
Removed some warnings
Youva Sep 24, 2024
9b5e644
Applied style.
Youva Sep 24, 2024
c6cba7f
Changed push_back to emplace_back
Youva Sep 24, 2024
59b17e1
Return bool l. 432
Youva Sep 24, 2024
81ad26f
Fix unusedStructMember and containerOutOfBounds
Youva Sep 24, 2024
98f7e72
Coding style modification.
Youva Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions plugins/alembic/module/vtkF3DAlembicReader.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,11 @@
#ifndef vtkF3DAlembicReader_h
#define vtkF3DAlembicReader_h

#include <memory>
#include <vtkNew.h>
#include <vtkPolyDataAlgorithm.h>
#include <vtkVersion.h>

#include <memory>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to move this

class vtkF3DAlembicReader : public vtkPolyDataAlgorithm
{
public:
Expand Down
13 changes: 13 additions & 0 deletions plugins/alembic/module/vtkF3DAlembicReader.h.rej
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff a/plugins/alembic/module/vtkF3DAlembicReader.h b/plugins/alembic/module/vtkF3DAlembicReader.h (rejected hunks)
@@ -14,10 +14,10 @@
#ifndef vtkF3DAlembicReader_h
#define vtkF3DAlembicReader_h

+#include <memory>
#include <vtkNew.h>
#include <vtkPolyDataAlgorithm.h>
#include <vtkVersion.h>
-#include <memory>

class vtkF3DAlembicReader : public vtkPolyDataAlgorithm
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove this file

9 changes: 9 additions & 0 deletions plugins/native/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,15 @@ f3d_plugin_declare_reader(
FORMAT_DESCRIPTION "3D Gaussian splats"
)

f3d_plugin_declare_reader(
NAME QuakeMDL
EXTENSIONS mdl
MIMETYPES application/vnd.mdl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you have a small .mdl file with a creative commons license ?

VTK_IMPORTER vtkQuakeMDLImporter
FORMAT_DESCRIPTION "Quake 1 MDL model"
)


f3d_plugin_build(
NAME native
VERSION 1.0
Expand Down
1 change: 1 addition & 0 deletions plugins/native/module/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
set(classes
vtkF3DSplatReader
vtkQuakeMDLImporter
)

set(_no_install "")
Expand Down
Loading