FIX: Add getters for camera parameters #1419

f3d-app · Oct 6, 2024 · 6c1687c · 6c1687c
1 parent 8ed0310
commit 6c1687c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/python/F3DPythonBindings.cxx b/python/F3DPythonBindings.cxx
@@ -271,9 +271,9 @@ PYBIND11_MODULE(pyf3d, module)
     .def("add_azimuth", &f3d::camera::addAzimuth)
     .def("add_yaw", &f3d::camera::addYaw)
     .def("add_elevation", &f3d::camera::addElevation)
-    .def("get_azimuth", &f3d::camera::getAzimuth)
-    .def("get_yaw", &f3d::camera::getYaw)
-    .def("get_elevation", &f3d::camera::getElevation)
+    .def_property_readonly("azimuth", &f3d::camera::getAzimuth)
+    .def_property_readonly("yaw", &f3d::camera::getYaw)
+    .def_property_readonly("elevation", &f3d::camera::getElevation)
     .def("pitch", &f3d::camera::pitch)
     .def("set_current_as_default", &f3d::camera::setCurrentAsDefault)
     .def("reset_to_default", &f3d::camera::resetToDefault)

diff --git a/python/testing/test_camera.py b/python/testing/test_camera.py
@@ -80,9 +80,9 @@ def test_moves():
     camera.dolly(10)
     angle = 30
     camera.roll(angle)
-    camera.azimuth(angle)
-    camera.yaw(angle)
-    camera.elevation(angle)
+    camera.add_azimuth(angle)
+    camera.add_yaw(angle)
+    camera.add_elevation(angle)
     camera.pitch(angle)