Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: hbmqtt don't support websockets >8.1 yet #3

Closed
wants to merge 5 commits into from
Closed

Fix: hbmqtt don't support websockets >8.1 yet #3

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented May 11, 2021

hbmqtt dont support websockets >8.1 yet

Traceback (most recent call last):
  File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/home/6d66/Repos/tellmqtt/tellmqtt/__main__.py", line 5, in <module>
    from hbmqtt.client import MQTTClient
  File "/home/6d66/Repos/tellmqtt/venv/lib/python3.8/site-packages/hbmqtt/client.py", line 13, in <module>
    from hbmqtt.session import Session
  File "/home/6d66/Repos/tellmqtt/venv/lib/python3.8/site-packages/hbmqtt/session.py", line 8, in <module>
    from hbmqtt.mqtt.publish import PublishPacket
  File "/home/6d66/Repos/tellmqtt/venv/lib/python3.8/site-packages/hbmqtt/mqtt/__init__.py", line 5, in <module>
    from hbmqtt.mqtt.packet import (
  File "/home/6d66/Repos/tellmqtt/venv/lib/python3.8/site-packages/hbmqtt/mqtt/packet.py", line 8, in <module>
    from hbmqtt.adapters import ReaderAdapter, WriterAdapter
  File "/home/6d66/Repos/tellmqtt/venv/lib/python3.8/site-packages/hbmqtt/adapters.py", line 6, in <module>
    from websockets.protocol import WebSocketCommonProtocol
ModuleNotFoundError: No module named 'websockets.protocol'

requirements.txt Outdated
@@ -1,3 +1,4 @@
websockets==8.1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.
It would be nice to add a comment in the file stating why this explicit requirement is needed (hopefully it can be removed when/if hbmqtt is updated)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found an issue njouanin/hbmqtt#239 that is only 16 days old. I feel like this PR might benefit from a few days of wait just in case someone else fixes this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to aMQTT, works. 😃

@ghost
Copy link
Author

ghost commented May 26, 2021

Creating a new PR for cleanliness

@ghost ghost closed this May 26, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant