Feature/shipper2 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-lyan
reviewed
Nov 19, 2024
| public interface CarRepository extends JpaRepository<Car, String> { | ||
| import java.util.Optional; | ||
|
|
||
| public interface CarRepository { |
There was a problem hiding this comment.
f-lab-lyan
reviewed
Nov 19, 2024
|
|
||
| @BeforeEach | ||
| void setUp() throws Exception { | ||
| this.truckerService = TruckerService.builder() |
f-lab-lyan
reviewed
Nov 19, 2024
|
|
||
| class TruckerServiceTest { | ||
|
|
||
| private TruckerService truckerService; |
There was a problem hiding this comment.
Suggested change
| private TruckerService truckerService; | |
| @InjectMock | |
| private TruckerService truckerService; | |
| @Mock | |
| private CarRepository carReposityr; | |
| ... |
f-lab-lyan
reviewed
Nov 19, 2024
|
|
||
| @Test | ||
| void createContract_성공하는_경우() { | ||
| TruckerDTO.ContractRequest req = new TruckerDTO.ContractRequest(); |
There was a problem hiding this comment.
Suggested change
| TruckerDTO.ContractRequest req = new TruckerDTO.ContractRequest(); | |
| // when | |
| when(carRepository.findById(any())).thenReturn(Optional.OfNullable(..)); | |
| TruckerDTO.ContractRequest req = new TruckerDTO.ContractRequest(); |
f-lab-lyan
reviewed
Nov 19, 2024
| @Slf4j | ||
| @Service | ||
| @RequiredArgsConstructor | ||
| @Builder |
There was a problem hiding this comment.
테스트를 위해서 라이브코드를 고치는 것이 좋은 것인가?
f-lab-lyan
reviewed
Nov 19, 2024
| @Slf4j | ||
| @Service | ||
| @RequiredArgsConstructor | ||
| @Builder | ||
| public class TruckerService { | ||
|
|
||
| private final CarRepository carRepository; |
There was a problem hiding this comment.
서비스에서 다른 리포지토리를 호출 하는 것에 대해서
2. test 는 Mock 사용하도록 수정 3. repository 는 interface 만 사용하도록 수정
f-lab-lyan
reviewed
Nov 26, 2024
Comment on lines
+17
to
+19
| private final AccountService accountService; | ||
| private final CarService carService; | ||
| private final ContractService contractService; |
There was a problem hiding this comment.
전 여전히 각각의 서비스들을 컨트롤러에 가져오는 것의 이점을 아직 잘 모르겠어요!! 이 경우에도 특정 URL은 하나의 서비스만 사용하는 것 같기도 하구요. :-)
f-lab-lyan
reviewed
Nov 26, 2024
| String contractId = truckerService.createContract(req); | ||
| ShipmentDTO.BasicInfo basicInfo = new ShipmentDTO.BasicInfo(); | ||
| basicInfo.setShipmentStatus("ready"); | ||
| ResponseEntity<ShipmentDTO.BasicInfo> basicInfoResponseEntity = new ResponseEntity<ShipmentDTO.BasicInfo>(basicInfo, HttpStatus.OK); |
There was a problem hiding this comment.
코드를 잠깐 봤는데, BasicInfoResponseEntity 자체를 mocking 해볼 수도 있을 것 같네요. :-) 이 얘기는 이따 멘토링 시간에 얘기해보죠. ㅎㅎ
f-lab-lyan
reviewed
Nov 26, 2024
| ShipmentDTO.BasicInfo basicInfo = new ShipmentDTO.BasicInfo(); | ||
| basicInfo.setShipmentStatus("ready"); | ||
| ResponseEntity<ShipmentDTO.BasicInfo> basicInfoResponseEntity = new ResponseEntity<ShipmentDTO.BasicInfo>(basicInfo, HttpStatus.OK); | ||
| Contract contract = Contract.builder().contractId("testId").build(); |
There was a problem hiding this comment.
Suggested change
| Contract contract = Contract.builder().contractId("testId").build(); | |
| Contract contract = mock(Contract.class); | |
| when(contract.getContractId()).thenReturn("testId"); |
f-lab-lyan
reviewed
Nov 26, 2024
Comment on lines
+52
to
+54
| ShipmentDTO.BasicInfo basicInfo = new ShipmentDTO.BasicInfo(); | ||
| basicInfo.setShipmentStatus("ready"); | ||
| ResponseEntity<ShipmentDTO.BasicInfo> basicInfoResponseEntity = new ResponseEntity<ShipmentDTO.BasicInfo>(basicInfo, HttpStatus.OK); |
There was a problem hiding this comment.
Suggested change
| ShipmentDTO.BasicInfo basicInfo = new ShipmentDTO.BasicInfo(); | |
| basicInfo.setShipmentStatus("ready"); | |
| ResponseEntity<ShipmentDTO.BasicInfo> basicInfoResponseEntity = new ResponseEntity<ShipmentDTO.BasicInfo>(basicInfo, HttpStatus.OK); | |
| ShipmentDTO.BasicInfo basicInfo = mock(ShipmentDTO.BasicInfo.class); | |
| when(basicInfo.getShipmentStatus()).thenReturn("ready"); | |
| ResponseEntity<ShipmentDTO.BasicInfo> basicInfoResponseEntity = mock(...); | |
| when(basicInfoReponseEntity.getBasicInfo()).thenReturn(basicInfo); |
f-lab-lyan
reviewed
Dec 10, 2024
| @@ -16,12 +17,14 @@ public class CarService { | |||
|
|
|||
| private final CarRepository carRepository; | |||
|
|
|||
| @Async(value = "taskExecutor") | |||
| public String createCar(TruckerDTO.CarRequest req) { | |||
There was a problem hiding this comment.
Suggested change
| public String createCar(TruckerDTO.CarRequest req) { | |
| String car = createCar(...); |
f-lab-lyan
approved these changes
Dec 10, 2024
|
f-lab-lyan
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.