화주 운송등록 추가 #3
Merged
화주 운송등록 추가 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-lyan
reviewed
Nov 5, 2024
| import lombok.RequiredArgsConstructor; | ||
| import org.springframework.http.HttpStatus; | ||
| import org.springframework.http.ResponseEntity; | ||
| import org.springframework.web.bind.annotation.*; |
There was a problem hiding this comment.
*를 풀어서 모든 import가 보이도록 해주세요.
f-lab-lyan
reviewed
Nov 5, 2024
| private String comment; | ||
|
|
||
| @Builder | ||
| public Shipment(ShipmentDTO.ShipmentRequest req) { |
There was a problem hiding this comment.
Entity에 DTO의 의존성을 넣는 것에 대해서
2. 계약 체결 추가
|
f-lab-lyan
reviewed
Nov 12, 2024
| @@ -40,4 +42,13 @@ public ShipmentDTO.BasicInfo get(String shipmentId) { | |||
| } | |||
| return null; | |||
| } | |||
|
|
|||
| @Transactional | |||
There was a problem hiding this comment.
Transactional은 왜 필요한가요?
f-lab-lyan
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.