truck-matching 모듈화 및 기존 소스 member 쪽으로 이관 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
각각의 모듈 아래에 아직 gradle 관련 파일들이 있는 것 같아요. 정리해주시겠어요? |
f-lab-lyan
reviewed
Nov 1, 2024
build.gradle
Outdated
| } | ||
|
|
||
| tasks.named('test') { | ||
| useJUnitPlatform() | ||
| project(':module-trucker') { |
There was a problem hiding this comment.
이 내용들은 각각의 build.gradle에 있는 것이 좋을 것 같습니다. :-)
f-lab-lyan
reviewed
Nov 1, 2024
| } | ||
| } | ||
|
|
||
| dependencies { |
There was a problem hiding this comment.
lombok은 gradle lombok 플러그인을 도입해 볼까요?
f-lab-lyan
reviewed
Nov 1, 2024
| mavenCentral() | ||
| } | ||
|
|
||
| dependencies { |
There was a problem hiding this comment.
나중엔 어떻게 될지 모르겠지만, 지금은 필요없는 디펜던시들이 많은 것 같습니다. 일단 깔끔하게 지우고 시작해보는건 어떨까요?
f-lab-lyan
reviewed
Nov 1, 2024
There was a problem hiding this comment.
서비스 테스트는 유닛 테스트로 바꿔보면 좋을 것 같습니다.
|
f-lab-lyan
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.