Release 1.2.0 #92
Open
Release 1.2.0 #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mason136
reviewed
Sep 21, 2024
| "(:sex IS NULL OR i.sex = :sex) AND " + | ||
| "i.saleState IN ('ON_SALE', 'TEMPORARILY_SOLD_OUT')") | ||
| Page<Item> findAllByFilters(@Param("minPrice") Integer minPrice, | ||
| List<Item> findAllByFilters(@Param("minPrice") Integer minPrice, |
There was a problem hiding this comment.
QueryDsl 적용해서 동적쿼리 만들어주세요
아래처럼 불필요한 조건들이 없는 것이 더 명확합니다.
(:minPrice IS NULL OR i.salePrice >= :minPrice) | "(:storeId IS NULL OR i.store.id = :storeId) AND " + | ||
| "(:sex IS NULL OR i.sex = :sex) AND " + | ||
| "i.saleState IN ('ON_SALE', 'TEMPORARILY_SOLD_OUT')") | ||
| Long countByFilters(@Param("minPrice") Integer minPrice, |
There was a problem hiding this comment.
count 쿼리도 querydsl로 처리해주세요
|
|
||
| @Transactional(readOnly = true) | ||
| @Cacheable(cacheNames = "ITEM_LIST", | ||
| key = "#categoryId + ':' + #storeId + ':' + #pageable.pageNumber", |
There was a problem hiding this comment.
캐시 키에 pageNumber가 왜 있나요??
| @Transactional(readOnly = true) | ||
| @Cacheable(cacheNames = "ITEM_LIST", | ||
| key = "#categoryId + ':' + #storeId + ':' + #pageable.pageNumber", | ||
| condition = "#pageable.pageNumber <= 3", |
| key = "#itemId", | ||
| cacheManager = "cacheManager") | ||
| @Transactional | ||
| public void deleteItemDetails(Long itemId) { |
There was a problem hiding this comment.
나중에 구현하실 메서들에는 주석으로 설명 넣어주시는게 좋습니다.
// TODO 추후 구현 예정
| @@ -61,6 +63,7 @@ public void updateToSoldOut(Long itemOptionId, Boolean isTemporarily) { | |||
| .orElseThrow(() -> new ApiException(ErrorEnum.INVALID_REQUEST)); | |||
|
|
|||
| itemOption.beSoldOut(isTemporarily); | |||
| itemOption.getItem().renewSaleState(); | |||
There was a problem hiding this comment.
itemOption의 beSoldOut 메서드 안에서 item.renewSaleState를 호출하는게 맞지 않을까요??
| public void reduceStock(Long itemOptionId, Integer amount) { | ||
| ItemOption itemOption = itemOptionRepository.findById(itemOptionId) | ||
| .orElseThrow(() -> new ApiException(ErrorEnum.INVALID_REQUEST)); | ||
| Long stocksAfter = itemOption.reduceStocksCount(amount); |
There was a problem hiding this comment.
reduceStocksCount에서 남은 재고수를 반환하는 것보다는 itemOption에서 stockCount 필드를 직접 접근하는게 맞지 않을까요?
mason136
reviewed
Sep 21, 2024
| redisCacheConfigMap.put("ITEM_LIST_COUNT", defaultConfig.entryTtl(Duration.ofDays(1))); | ||
| redisCacheConfigMap.put("TOP_ITEMS_STORE", defaultConfig.entryTtl(Duration.ofMinutes(10))); | ||
| redisCacheConfigMap.put("TOP_ITEMS_CATEGORY", defaultConfig.entryTtl(Duration.ofMinutes(10))); | ||
| redisCacheConfigMap.put("STOCKS", defaultConfig.entryTtl(Duration.ofMinutes(10))); |
There was a problem hiding this comment.
이렇게 하면 모든 캐시에 적용되는데 ttl 설정을 추가하신 이유가 있을까요??
mason136
reviewed
Sep 24, 2024
| @@ -39,13 +39,33 @@ jobs: | |||
| push: true | |||
| tags: wedowhatwedo/mall-qa:latest | |||
|
|
|||
| - name: Deploy | |||
| - name: Deploy to server 1 | |||
There was a problem hiding this comment.
파일 명이 qa-deploy 맞나요?? 개발서버 또는 운영서버에 배포하는거아닌가요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
조회 성능 개선 및 캐시 설정 완료했습니다.
감사합니다(__)