Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1] 지출내역 Database 구현 #2

Merged
merged 10 commits into from
Nov 28, 2024
Merged

[#1] 지출내역 Database 구현 #2

merged 10 commits into from
Nov 28, 2024

Conversation

ksw4015
Copy link
Collaborator

@ksw4015 ksw4015 commented Nov 25, 2024

변경사항

  • MyBudgetDatabase가 추가되었습니다.
  • SpendingDao, SpendingEntity가 추가되었습니다.

추가사항

  • xml resource에 있는 integers.xml과 arrays.xml은 어제 말씀나눈대로 삭제 후 상수나 enum으로 정의할 예정입니다.

@ksw4015 ksw4015 added the data data layer develop label Nov 25, 2024
@ksw4015 ksw4015 added this to the 데이터 계층 구현 milestone Nov 25, 2024
@ksw4015 ksw4015 requested a review from f-lab-Toru November 25, 2024 10:20
@ksw4015 ksw4015 self-assigned this Nov 25, 2024
Copy link

@f-lab-Toru f-lab-Toru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다. 저번 프로젝트부터 테스트코드를 꼼꼼하게 작성하시는 습관이 잘 길러진 거 같아요.

@@ -0,0 +1,30 @@
<?xml version="1.0" encoding="utf-8"?>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이렇게 integer와 integer-array 혹은 다른 타입의 resource 를 정의할 때, 나중에는 번거로워서 스킵하는 일이 생깁니다. 그러지 않도록 습관화하는게 좋을 거 같아요.

@ksw4015 ksw4015 merged commit c026e20 into main Nov 28, 2024
2 checks passed
@ksw4015 ksw4015 deleted the feature/1 branch December 11, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data data layer develop
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants