회원관리 기능, 로그인, 로그아웃 기능 개발 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 회원 가입 - 회원 정보 조회 - 회원 정보 수정 - build.gradle 의존성 추가
-로그인 -로그아웃 -세션 정보 확인
|
이 커밋은 다른 PR에서 처리된 것이 아닌가요? |
f-lab-lyan
reviewed
Dec 10, 2024
app/build.gradle
Outdated
|
|
||
| implementation 'org.springframework.boot:spring-boot-starter-web' | ||
| implementation 'org.springframework.boot:spring-boot-starter-validation' | ||
| compileOnly 'org.projectlombok:lombok' |
There was a problem hiding this comment.
로그인, 로그아웃, 회원 관리 기능 코드에 대하여 아래와 같은 작업을 수행했습니다. - 필요 없는 import문 정리 - 주석 수정 - 사용 되지 않는 코드 삭제 - 반복되는 코드 리팩토링
- 회원 가입 시 learning에 여러 언어를 넣었는데도 [] 였던 버그 해결
f-lab-lyan
reviewed
Dec 11, 2024
| public String login(@Valid @ModelAttribute LoginForm loginForm, BindingResult bindingResult, HttpServletRequest request) { | ||
|
|
||
| if(bindingResult.hasErrors()) { | ||
| return "not ok"; |
There was a problem hiding this comment.
f-lab-lyan
reviewed
Dec 11, 2024
| } | ||
|
|
||
| HttpSession session = request.getSession(); | ||
| session.setAttribute(SessionConst.LOGIN_MEMBER, member); |
There was a problem hiding this comment.
scale out 했을때(서버가 2대가 됐을 때)는 어떻게 동작하는 것인가요?
f-lab-lyan
reviewed
Dec 11, 2024
| public class LoginController { | ||
| private final MemberRepository memberRepository; | ||
| @PostMapping("/login") | ||
| public String login(@Valid @ModelAttribute LoginForm loginForm, BindingResult bindingResult, HttpServletRequest request) { |
There was a problem hiding this comment.
@RequestBody을 받지 않은 이유는 Form타입으로 받는 것이 더 좋다고 판단했습니다.
f-lab-lyan
reviewed
Dec 11, 2024
| @RestController | ||
| @RequiredArgsConstructor | ||
| public class LoginController { | ||
| private final MemberRepository memberRepository; |
There was a problem hiding this comment.
MemberService를 통해서 MemeberRepository접근하는 것이 더 좋아보이긴 하네요.
f-lab-lyan
reviewed
Dec 11, 2024
Comment on lines
+23
to
+25
| Member member = new Member(memberForm); | ||
| memberRepository.save(member); | ||
| return "ok"; |
There was a problem hiding this comment.
Suggested change
| Member member = new Member(memberForm); | |
| memberRepository.save(member); | |
| return "ok"; | |
| return new Member(memberForm); |
f-lab-lyan
reviewed
Dec 11, 2024
| // 사용자 프로필 조회 | ||
| @GetMapping("/{user_id}") | ||
| public Member findMember(@PathVariable(value = "user_id") Long user_id){ | ||
| return memberRepository.findById(user_id); |
There was a problem hiding this comment.
Suggested change
| return memberRepository.findById(user_id); | |
| return new Member(1, ....); |
f-lab-lyan
reviewed
Dec 11, 2024
|
|
||
| // 사용자 프로필 조회 | ||
| @GetMapping("/{user_id}") | ||
| public Member findMember(@PathVariable(value = "user_id") Long user_id){ |
There was a problem hiding this comment.
Suggested change
| public Member findMember(@PathVariable(value = "user_id") Long user_id){ | |
| public Member findMember(@PathVariable(value = "user_id") Long userId){ |
f-lab-lyan
reviewed
Dec 11, 2024
| @Slf4j | ||
| @Repository | ||
| public class MemberRepository { | ||
| private static Map<Long, Member> store = new HashMap<>(); |
There was a problem hiding this comment.
이 부분과 관련된 얘기는 다음주에 해보죠.
f-lab-lyan
reviewed
Dec 11, 2024
| private Integer point; | ||
| private Integer credibility; | ||
|
|
||
| private static long sequence = 0L; |
There was a problem hiding this comment.
데이터 동시성 이슈가 있을 수 있겠네요.
There was a problem hiding this comment.
f-lab-lyan
reviewed
Dec 11, 2024
| @@ -0,0 +1,52 @@ | |||
| package org.example.domain.member.dto; | |||
There was a problem hiding this comment.
이 객체는 Entity에 더 가까운 것 같습니다.
f-lab-lyan
reviewed
Dec 11, 2024
There was a problem hiding this comment.
이 테스트는 지워도 괜찮을 것 같습니다.
f-lab-lyan
reviewed
Dec 11, 2024
| import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath; | ||
| import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status; | ||
|
|
||
| @WebMvcTest(MemberController.class) |
f-lab-lyan
reviewed
Dec 11, 2024
| @WebMvcTest(MemberController.class) | ||
| class MemberControllerTest { | ||
| @Autowired | ||
| private MockMvc mockMvc; |
f-lab-lyan
reviewed
Dec 11, 2024
| .param("nationality", memberForm.getNationality()) | ||
| .param("native_lang", memberForm.getNative_lang()) | ||
| .param("introduction", memberForm.getIntroduction())) | ||
| .andExpect(status().isOk()); |
There was a problem hiding this comment.
값이 제대로 나오는지에 대한 테스트도 필요할 것 같아요.
lombok plugin을 추가했습니다.
자동으로 생성된 AppTest.java는 현재 필요하지 않아 삭제했습니다.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
회원 관리 기능
로그인, 로그아웃
테스트