Refactor: #7, #8 코드 리뷰 반영 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Login, Logout의 일부 DTO를 수정했습니다. 필드가 많거나 Optional이 있는 DTO에는 빌더 패턴을 적용했습니다.
각각의 특징에 맞게 빌더, 생성자를 사용하도록 코드를 수정했습니다.
- 필요하지 않는 테스트 제거 - 테스트 코드 리팩토링
- 필요 없는 코드 삭제 - 테스트 코드 수정
- 필요 없는 코드 삭제 - 질문 테스트 코드 수정
|
f-lab-lyan
reviewed
Jan 1, 2025
| @RestControllerAdvice | ||
| public class ErrorController { | ||
| @ResponseStatus(HttpStatus.BAD_REQUEST) | ||
| @ExceptionHandler(RuntimeException.class) |
There was a problem hiding this comment.
나중에 custom exception을 만들어서 처리하면 더 좋을 것 같네요.
f-lab-lyan
reviewed
Jan 1, 2025
| import org.springframework.web.servlet.ModelAndView; | ||
|
|
||
| @Slf4j | ||
| @Profile("!test") |
There was a problem hiding this comment.
프로덕션 코드에 테스트 관련된 설정이 들어가는 것은 일반적으로 좋은 방식은 아닌 것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7, #8 코드 리뷰를 토대로 코드를 수정했습니다.