[#3] 약국 및 병원 데이터 가져오기 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
JHwan96
commented
Aug 26, 2024
JHwan96
commented
- 공공데이터인 약국 정보 서비스, 병원 정보 서비스 가져오기 [건강보험심사평가원]
- 의료기관별 상세 정보 [건강보험심사평가원]
- 데이터 내부 문제로 처리 방법을 다시 생각해볼 예정
- spring boot starter web 추가 - AppTest 내용 임시 삭제
- 컨트롤러 생성을 위해 더미데이터 추가
- 임시 확인을 위해 main문 추가 (차후 main문 삭제 후 component로 변경할 예정) - 값이 없는 경우는 null로 대체 - 서비스 키 제거 후 commit - 차후 코드 리팩토링 및 DrugstoreDto 반환하도록 변경할 예정
- 임시 확인을 위해 main문 추가 (차후 main문 삭제 후 component로 변경할 예정) - 값이 없는 경우는 null로 대체
- 특정 개수만큼 읽을 때, 전체 페이지 개수 반환하는 메서드 추가 - 예외 처리는 차후에 작업할 예정
- Application-secret.yml에 Api key 저장
f-lab-lyan
reviewed
Aug 27, 2024
| @Component | ||
| public class DrugstoreApi { | ||
| @Autowired | ||
| KeyInfo keyInfo; |
There was a problem hiding this comment.
@Autowired대신 Contructor injection을 사용해 주세요.
f-lab-lyan
reviewed
Aug 27, 2024
| private final int rowSize = 1000; //한 페이지 결과 수 | ||
| private String url; | ||
|
|
||
| @PostConstruct |
There was a problem hiding this comment.
@PostContruct말고 다른 방식으로 변수를 초기화 하면 좋을 것 같습니다.
f-lab-lyan
reviewed
Aug 27, 2024
| public List<DrugstoreDto> getDrugstoreInfo(int pageNo) throws IOException, ParserConfigurationException, SAXException { | ||
| List<DrugstoreDto> drugstoreDtoList = new ArrayList<>(); | ||
| String realUrl = url + page + pageNo; | ||
| System.out.println(keyInfo.getServerKey()); |
f-lab-lyan
reviewed
Aug 27, 2024
| Node node = nodeList.item(i); | ||
| if (node.getNodeType() == Node.ELEMENT_NODE) { | ||
| Element element = (Element) node; | ||
| DrugstoreDto drugstoreDto = DrugstoreDto.builder() |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.