[CT-2-2-1] Theme 간단 셋업, 차트게임 기능 - UI 컴포넌트 제작 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feature/ct-2-2-chart-game-presentation-view
|
nosorae
commented
Jun 2, 2024
| volumeWeightedAveragePrice = volumeWeightedAveragePrice | ||
| ) | ||
|
|
||
| fun Tick.asEntity(chartId: Long) = |
There was a problem hiding this comment.
버그 수정중에 발생한 코드인데 같은 파일이라 섞여들어갔습니다. #32 여기서도 추가될 것입니다.
f-lab-nathan
reviewed
Jun 3, 2024
...main/java/com/yessorae/data/source/network/polygon/util/DefaultChartRequestArgumentHelper.kt
Show resolved
Hide resolved
presentation/src/main/java/com/yessorae/presentation/ui/designsystem/component/Grid.kt
Show resolved
Hide resolved
| @@ -3,45 +3,115 @@ package com.yessorae.presentation.ui.chartgame.model | |||
| import com.yessorae.domain.entity.tick.Tick | |||
|
|
|||
| data class ChartGameScreenState( | |||
There was a problem hiding this comment.
Q; State에 필드가 너무 많은 것은 아닐까요? 어느정도의 수가 적절할지 고민해보셨을까요?
There was a problem hiding this comment.
아뇨, 고민해보지 못했습니다. 적절한 필드 개수를 고민해보겠습니다!
불필요한 게 없는지, 이 클래스 안에 같이 있어야할 필드들인지까지만 생각해봤습니다.
혹시 예시를 얻을 수 있을까요?
Preview 로 데이터를 바꿔가며 고칩니다. |
f-lab-nathan
merged commit 718f203
into
feature/ct-2-chart-game-presentation
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #25
*UI 전체 완성을 한 번의 PR로 가면 변경점이 너무 많아져 UI컴포넌트에서 한 번 끊어 PR을 올립니다.
[CT-2-2-2]에서 CT-2가 마무리됩니다.
*현재 디자인이 구려보일 수 있습니다. 크기/간격/색상 등은 지금 크게 씬경쓰지 않고 나중에 쉽게 조정할 수 있는 코드를 작성하는 것 에 집중했습니다.
*브랜치 이름이 ct-2-2-1-chart-game-presentation-theme-and-component 인 게 더 좋았겠습니다..
Overview