레시피 업로드 Domain, Data 영역을 정의해 보았습니다. #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-barry
reviewed
Jul 22, 2024
| import RxSwift | ||
|
|
||
| protocol AddRecipeInteractorDelegate: AnyObject { | ||
| func didLoadRecipeData(viewModel: AddRecipeViewModel) |
There was a problem hiding this comment.
didLoadRecipe 정도로 해도 괜찮을 것 같아요. viewModel을 넘겨서 구성하는데 너무 도메인적인 네이밍 같아요.
f-lab-barry
reviewed
Jul 22, 2024
| ) -> Single<Result<Recipe, AddRecipeError>> | ||
| } | ||
|
|
||
| class AddRecipeUseCaseImpl: AddRecipeUseCase { |
f-lab-barry
reviewed
Jul 22, 2024
Comment on lines
+37
to
+47
| guard !images.isEmpty else { | ||
| return .just(.failure(.noImages)) | ||
| } | ||
|
|
||
| guard !title.isBlank else { | ||
| return .just(.failure(.titleIsEmpty)) | ||
| } | ||
|
|
||
| guard description.count > 10 else { | ||
| return .just(.failure(.descriptionTooShort)) | ||
| } |
f-lab-barry
reviewed
Jul 22, 2024
Comment on lines
50
to
51
| ) | ||
| -> Single<T> { |
There was a problem hiding this comment.
어떤식으로 줄바꿈 해야할지 몰라서 저런식으로 한건데 저 부분은 50번째 줄로 올리겠습니다!
f-lab-barry
reviewed
Jul 22, 2024
| ) | ||
| } | ||
|
|
||
| formDataRequest.finalize() |
There was a problem hiding this comment.
finalize는 전체 요청이 완성된후 1번만 호출되어야 하기 떄문입니다
f-lab-barry
approved these changes
Jul 23, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
레시피 업로드 도메인 영역 정의
레시피 업로드 데이터 영역 정의