RecipeDetailInteractor, RecipeListInteractor 의 ouput을 제거, 네이밍을 수정하였습니다. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-barry
reviewed
Jul 17, 2024
| @@ -9,16 +9,18 @@ import UIKit | |||
|
|
|||
| final class RecipeListViewController: UIViewController { | |||
|
|
|||
| private var interactor: RecipeListInteractor | |||
| private var recipes: [RecipeListItemViewModel] = [] | |||
| private var interactor: RecipeListInteractorImpl | |||
f-lab-barry
reviewed
Jul 17, 2024
| private let recipeListMapper = RecipeListMapper() | ||
| private let router: RecipeListRouterProtocol | ||
|
|
||
| init(interactor: RecipeListInteractorImpl, router: RecipeListRouterProtocol) { |
f-lab-barry
reviewed
Jul 17, 2024
| recipeID: Int | ||
| ) { | ||
|
|
||
| init(fetchRecipeDetailUseCase: FetchRecipeDetailUseCase, recipeID: Int) { |
There was a problem hiding this comment.
[b583cae] 다시 적용했습니다
f-lab-barry
reviewed
Jul 17, 2024
Comment on lines
42
to
44
| .subscribe(onSuccess: { [weak self] result in | ||
| self?.delegate?.fetchedRecipe(result: result) | ||
| }) |
There was a problem hiding this comment.
실패도 있습니다. 실패도 추가하겠습니다!
f-lab-barry
reviewed
Jul 17, 2024
| @@ -13,12 +13,12 @@ final class RecipeDetailViewController: UIViewController { | |||
|
|
|||
| private let contentView = RecipeDetailView() | |||
| private let customNavigationBar = CustomNavigationBar() | |||
| private let interactor: RecipeDetailInteractor | |||
| private let interactor: RecipeDetailInteractorImpl | |||
There was a problem hiding this comment.
구현체 직접 보지 않도록 수정해주세요 (SOLID 원칙 생각해주세요)
f-lab-barry
reviewed
Jul 17, 2024
Comment on lines
70
to
73
| extension RecipeDetailViewController: Drawable { | ||
| var viewController: UIViewController? { | ||
| return self | ||
| } |
There was a problem hiding this comment.
router에서 viewController를 들고있는게 아니라 Drawble을 들고있는거에요?
이 PR에서 라우팅 맥락은 없는 것 같은데 여기 커밋에서 추가하신 이유가 있을까요? 맥락에 안맞는 것 같아서요.
There was a problem hiding this comment.
router의 Drawble프로토콜이 viewcontroller를 반환 하게 정의해 두었습니다
맥락에 맞지 않는코드가 같이 올라간거 같아요 주의 하겠습니다
There was a problem hiding this comment.
[433cc55] 제거 완료했습니다
|
inddoni
approved these changes
Jul 21, 2024
f-lab-barry
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RecipeDetailInteractor, RecipeListInteractor 의 ouput을 제거, 네이밍을 수정하였습니다.