-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fontbakery installation and add support for fontbakery extras dependencies installation #211
Conversation
Will address the comment in #210 (comment) in this branch |
@felipesanches mind having a look at the error with fontbakery execution in the test https://github.com/f-actions/font-bakery/actions/runs/6511875234/job/17688387802?pr=211? We run CI testing with fontbakery on this GHA implementation and it uses the custom check profile defined in: https://github.com/f-actions/font-bakery/blob/master/tests/check-test.py It looks like the custom fontbakery profile approach may need to be updated with recent developments in fontbakery? Edit: spun this out into a new issue in #212. We'll likely merge this PR before we address it |
More than willing to approach testing execution of FB through this Action differently if you have a better way to test. |
I reviewed Niko's new fontbakery installation logic and I am ok with the new backwards incompatible approach here released under a new major release version of this Action. We can ask any users who happen to need a fontbakery version < 0.9.0 (0.9.0 released last month) to stick with the v2 branch of this Action. Users should be pinning their Action execution to a v1, v2, v3 (upcoming for these changes) major release anyways. If they happen to be tracking main branch commits on the Action and are installing configured fixed versions of fontbakery, this is a situation where we break them but I think that this is an inappropriate use of the Action and we'll document around it so that they understand how to address the issue. I'm good with it. Thanks for the changes Nikolaus! |
…ken and we're on a nightly CI schedule see #211 (comment)
…y, no fallback default
|
Note to self: I added a backwards incompatible change to the |
Tested execution of this branch at c20d1b3 on a font development project that uses the Action in its CI pipeline. Execution took place without issues. I'm going to merge and cut the v3.0.0 release. Thanks to Nikolaus and Felipe for their help here! |
Supersedes #210.
Includes all of @madig's commits in that branch
Closes #165