IBX-1516: Enforced strict comparison between Limitation & Location path strings #263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3.3
Needs discussion
There is a mismatch between validation in Criterion and Limitation.
Criterion uses regex to check that Subtree Limitation is valid.
Subtree Limitation does not validate using this regex and "only" checks that Location path string and Limitation path string use the same beginning.
Early solution presented here ensures that values passed to Limition as path string is the same as the one present in Location (which ends with a trailing slash).
❗ However, because I'm not certain if they should be always exactly equal, I'm marking this as a BC break until discussed.
Checklist:
$ composer fix-cs
).@ezsystems/engineering-team
).