-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Chart.yaml #21
base: main
Are you sure you want to change the base?
Conversation
Set appVersion to Current Release Signed-off-by: Michael Raeck <[email protected]>
@@ -21,4 +21,4 @@ version: 0.1.0 | |||
# incremented each time you make changes to the application. Versions are not expected to | |||
# follow Semantic Versioning. They should reflect the version the application is using. | |||
# It is recommended to use it with quotes. | |||
appVersion: "1.16.0" | |||
appVersion: "v0.3.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
appVersion is updated during the release process. It doesn't matter what the version is here. :)
If you check and download the chart from the repository it will be set as such:
appVersion: v0.3.1
description: A Helm chart for Kubernetes
name: bitwarden-sdk-server
type: application
version: v0.3.1
Why would you like to update it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cloned the repo, assuming the Helm chart would work out of the box, but you're right in the end. :-)
I just thought maybe someone else might stumble upon this.
I guess it's a close then :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean it's not a problem to set it, I was just wondering what the usecase is. The problem is, that I will keep forgetting to set it on each release. :D That's why automated it. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah you need to run make helm.test.update
.
Set appVersion to Current Release
Problem Statement
Helm Deployment not working out of the Box. When i deploy the Helm Chart seperately from External Secrets Operator with the enabeled Option
Related Issue
Fixes #...
Proposed Changes
I fixed the Version, i am unsure if Renovate will pickit up properly
Checklist
git commit --signoff
make test
make reviewable