[Fix rubocop#1179] accept method calls on local variables in Rails/Re…

…flectionClassName
exterm · Nov 10, 2023 · a95f27c · a95f27c
1 parent dc6cebc
commit a95f27c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/rubocop/cop/rails/reflection_class_name.rb b/lib/rubocop/cop/rails/reflection_class_name.rb
@@ -40,7 +40,7 @@ class ReflectionClassName < Base
 
         def on_send(node)
           association_with_reflection(node) do |reflection_class_name|
-            return if reflection_class_name.value.send_type? && reflection_class_name.value.receiver.nil?
+            return if reflection_class_name.value.send_type? && !reflection_class_name.value.receiver&.const_type?
             return if reflection_class_name.value.lvar_type? && str_assigned?(reflection_class_name)
 
             add_offense(reflection_class_name.source_range) do |corrector|

diff --git a/spec/rubocop/cop/rails/reflection_class_name_spec.rb b/spec/rubocop/cop/rails/reflection_class_name_spec.rb
@@ -124,6 +124,12 @@
     RUBY
   end
 
+  it 'does not register and offense when parameter values is a method call on an object in a variable' do
+    expect_no_offenses(<<~RUBY)
+      has_many :accounts, class_name: the_class.name
+    RUBY
+  end
+
   context 'Ruby >= 3.1', :ruby31 do
     it 'registers an offense when shorthand syntax value is a local variable assigned a constant' do
       expect_offense(<<~RUBY)