Skip to content

[auto] Update Rust toolchain to 1.85.0 #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

expressvpn-iat-bot
Copy link
Collaborator

@expressvpn-iat-bot expressvpn-iat-bot requested a review from a team as a code owner February 21, 2025 01:43
Copy link

github-actions bot commented Feb 21, 2025

Code coverage summary for f66486c:

Filename                             Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
wolfssl-sys/src/lib.rs                     6                 0   100.00%           3                 0   100.00%          24                 0   100.00%           0                 0         -
wolfssl/src/chacha20_poly1305.rs          14                 2    85.71%           5                 0   100.00%          95                 2    97.89%           0                 0         -
wolfssl/src/context.rs                   170                83    51.18%          45                14    68.89%         344               131    61.92%           0                 0         -
wolfssl/src/error.rs                      19                 7    63.16%           5                 1    80.00%          51                 9    82.35%           0                 0         -
wolfssl/src/lib.rs                        64                14    78.12%          12                 2    83.33%          82                15    81.71%           0                 0         -
wolfssl/src/rng.rs                        19                 5    73.68%           4                 0   100.00%          47                 3    93.62%           0                 0         -
wolfssl/src/ssl.rs                       470               202    57.02%          80                24    70.00%        1065               281    73.62%           0                 0         -
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                    762               313    58.92%         154                41    73.38%        1708               441    74.18%           0                 0         -

✅ Region coverage 58% passes
✅ Line coverage 74% passes

@kp-mariappan-ramasamy kp-mariappan-ramasamy merged commit 3084ed6 into main Feb 21, 2025
10 checks passed
@kp-mariappan-ramasamy kp-mariappan-ramasamy deleted the gha/rust-toolchain-update branch February 21, 2025 04:28
@kp-mariappan-ramasamy
Copy link
Contributor

I skipped updating the rust edition in this PR, because of the following error:

error: expected identifier, found reserved keyword `gen`
    --> /work/github/expressvpn/wolfssl-rs/target/debug/build/wolfssl-sys-9fe6580f9f621073/out/bindings.rs:6681:9
     |
6681 |         gen: *mut WOLFSSL_GENERAL_NAME,
     |         ^^^ expected identifier, found reserved keyword
     |
help: escape `gen` to use it as an identifier
     |
6681 |         r#gen: *mut WOLFSSL_GENERAL_NAME,
     |         ++

The reserved keyword "gen" has not been handled by bindgen last released crate.
But its already addressed in bindgen master, rust-lang/rust-bindgen#3100

We can update the version after the next bindgen update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants