Skip to content

Commit

Permalink
Update numpy build constraints for numpy 1.25 (#35)
Browse files Browse the repository at this point in the history
Starting in numpy 1.25 (see
https://github.com/numpy/numpy/releases/tag/v1.25.0), the numpy C API is
backwards-compatible by default.

For python 3.9+, we should be able to drop the specific numpy build
requirements and use `numpy>=1.25`, which is currently
backwards-compatible to `numpy>=1.19`.

In the future, the python <3.9 requirements could be dropped and the
lower numpy pin could correspond to the oldest supported version for the
current lower python pin.
  • Loading branch information
adrianeboyd authored Jul 20, 2023
1 parent 993d8d1 commit dd82264
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
6 changes: 2 additions & 4 deletions build-constraints.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
# build version constraints for use with wheelwright + multibuild
numpy==1.21.0; python_version<='3.9'
numpy==1.21.3; python_version=='3.10'
numpy==1.23.2; python_version=='3.11'
numpy; python_version>='3.12'
numpy==1.21.0; python_version<'3.9'
numpy>=1.25.0; python_version>='3.9'
3 changes: 2 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
requires = [
"setuptools",
"cython>=0.25",
"numpy>=1.21.0",
"numpy>=1.21.0; python_version < '3.9'",
"numpy>=1.25.0; python_version >= '3.9'",
"thinc>=8.1.0.dev2,<9.1.0",
]
build-backend = "setuptools.build_meta"

0 comments on commit dd82264

Please sign in to comment.