Remove support for TorchScript tracing #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldk
force-pushed
the
maintenance/yank-torchscript-support
branch
from
7e2599a to
fd49ae7
Compare
We added support for TorchScript tracing a while back, so that models can be exported to ONNX. However, the support relies on metaclasses, which breaks with torch.compile in the latest PyTorch versions. However, PyTorch now provides a TorchDynamo-based ONNX exporter: https://pytorch.org/docs/stable/onnx_dynamo.html So it's time to yank TorchScript tracing support and remove all the fragile dataclass/tuple/dict polymorphism.
danieldk
force-pushed
the
maintenance/yank-torchscript-support
branch
from
fd49ae7 to
8b3abc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We added support for TorchScript tracing a while back, so that models
can be exported to ONNX. However, the support relies on metaclasses,
which breaks with torch.compile in the latest PyTorch versions. However,
PyTorch now provides a TorchDynamo-based ONNX exporter:
https://pytorch.org/docs/stable/onnx_dynamo.html
So it's time to yank TorchScript tracing support and remove all the
fragile dataclass/tuple/dict polymorphism.
Checklist