Add repository abstraction #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, loading models was done with a bunch of standalone functions for Hugging Face Hub and fsspec. These functions had a lot of overlap and adding yet another storage backend would require duplicating the same functions again and littering them through the code base. This change does away with all the standalone functions and introduces the `Repository` API. This base class requires implementations to define a few basic operations. More complex operations are implemented in terms of these basic operations and generic across repository types. Initially there are two repository types, `HfHubRepository` and `FsspecRepository`. There are also two wrappers for `Repository` instances that implement model operations (`ModelRepository`) and tokenizer operations (`TokenizerRepository`).
danieldk
added
type/feature
Co-authored-by: Madeesh Kannan <[email protected]>
Co-authored-by: Madeesh Kannan <[email protected]>
shadeMe
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this change, loading models was done with a bunch of standalone functions for Hugging Face Hub and fsspec. These functions had a lot of overlap and adding yet another storage backend would require duplicating the same functions again and littering them through the code base.
This change does away with all the standalone functions and introduces the
RepositoryAPI. This base class requires implementations to define a few basic operations. More complex operations are implemented in terms of these basic operations and generic across repository types.Initially there are two repository types,
HfHubRepositoryandFsspecRepository. There are also two wrappers forRepositoryinstances that implement model operations (ModelRepository) and tokenizer operations (TokenizerRepository).Checklist