-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/split create update answers #98
Open
maddaicita
wants to merge
52
commits into
expertiza:main
Choose a base branch
from
maddaicita:refactor/split-create-update-answers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactor/split create update answers #98
maddaicita
wants to merge
52
commits into
expertiza:main
from
maddaicita:refactor/split-create-update-answers
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate method into response model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a clear separation between the logic for creating and updating answer records associated with responses. Previously, a single method create_update_answers handled both creation and updating, which worked well but did not align with the single-responsibility principle.
The changes split this functionality into two distinct methods: create_answers and update_answers. This ensures that each method has a single responsibility and improves the overall readability and maintainability of the codebase.
Key Changes:
By refactoring this logic, we also enhance error handling and make debugging more straightforward. These changes are expected to facilitate future extensions of the response and answer features without adding complexity to the existing logic.