Skip to content

Commit

Permalink
Merge branch 'feature/cloud-support'
Browse files Browse the repository at this point in the history
  • Loading branch information
@Basvanderlouw
Basvanderlouw committed Jan 27, 2021
2 parents 98ae468 + 1bee29b commit 0bcbf34
Show file tree
Hide file tree
Showing 2 changed files with 69 additions and 38 deletions.
97 changes: 60 additions & 37 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,69 +1,92 @@
## 3.2.0 (2021-01-27)

[View Release](https://Basvanderlouw:[email protected]/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/3.2.0)

* [BUGFIX][BACI-391] - Fix error "Cannot open file for write dictionary" when locale file is non-existent *(Ruben Panis)*
* [FEATURE][S-323] Added fallback for e.g., Magento Cloud, where /app directory has no write access *(Bas van der Louw)*


## 3.1.2 (2020-11-16)

[View Release](https://Basvanderlouw:[email protected]/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/3.1.2)

* [BUGFIX] Solved Uncaught TypeError: preg_match_all() expects parameter 2 to be string, bool given *(Mr. Lewis)*


## 3.1.1 (2020-11-05)

[View Release](https://Basvanderlouw:[email protected]/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/3.1.1)

* [BUGFIX] Solved empty $fileRow variable *(Mr. Lewis)*
* [BUGFIX] Solved Uncaught TypeError: strpos() expects parameter 1 to be string, object given *(Mr. Lewis)*


## 3.1.0 (2020-10-22)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/3.1.0)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/3.1.0)

* [FEATURE] [BACI-154] Added strict_types=1 and added License *(Lewis Voncken)*


## 3.0.1 (2020-10-21)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/3.0.1)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/3.0.1)

* [REFACTOR] [BACI-157] Removed setup_version from module.xml *(Lewis Voncken)*


## 3.0.0 (2020-10-21)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/3.0.0)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/3.0.0)

* [FEATURE] [BACI-157] Converted Schema Setup Scripts to db_schema.xml *(Lewis Voncken)*


## 2.1.13 (2020-10-15)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/2.1.13)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/2.1.13)

* [REFACTOR] [BACI-123] solved errors based on php code sniffer *(Lewis Voncken)*


## 2.1.12 (2020-10-15)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/2.1.12)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/2.1.12)

* [REFACTOR] Removed unused code or added suppression when unused code is allowed and applied phpcs fixes *(Lewis Voncken)*


## 2.1.11 (2020-03-18)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/2.1.11)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/2.1.11)

* [BUGFIX] - Check file exists before processing *(Ruben Panis)*


## 2.1.10 (2019-11-26)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/2.1.10)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/2.1.10)

* Make sure JS translations keep working after import *(Arnoud Beekman)*


## 2.1.9 (2019-10-07)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/2.1.9)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/2.1.9)

* [BUGFIX] "context" argument breaks adminhtml page in Magento 2.3.3. *(Boris van Katwijk)*


## 2.1.8 (2019-05-27)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/2.1.8)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/2.1.8)

* [BUGFIX] Fixed module not working on adminurl's other than 'storemanager' *(Rens Wolters)*


## 2.1.7 (2019-01-11)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/2.1.7)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/2.1.7)

* [TASK] Added additional Filters and added a getter so a Plugin can be written *(Lewis Voncken)*
* [TASK] Refine Filter *(Lewis Voncken)*
Expand All @@ -72,14 +95,14 @@

## 2.1.6 (2018-12-05)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/2.1.6)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/2.1.6)

* [BUGFIX] Fixed acl not being properly defined for controllers *(René Schep)*


## 2.1.5 (2018-11-29)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/2.1.5)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/2.1.5)

* Added check function createPhrase *(thokiller)*
* added instance check Phrase *(thokiller)*
Expand All @@ -89,7 +112,7 @@

## 2.1.4 (2018-06-18)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/2.1.4)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/2.1.4)

* [TASK] added dependency sequence for Magento_Translation in module.xml *(Jeroen Coppelmans)*
* [TASK] added Experius_Core to module.xml sequence as well *(Jeroen Coppelmans)*
Expand All @@ -98,29 +121,29 @@

## 2.1.3 (2018-05-15)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/2.1.3)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/2.1.3)

* [TASK] Applied CodeQuality fixes *(Lewis Voncken)*
* [BUGFIX] Solved incorrect dependency injection *(Lewis Voncken)*


## 2.1.2 (2018-05-02)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/2.1.2)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/2.1.2)

* [DOCS] Updated the README.md with clear information *(Lewis Voncken)*


## 2.1.1 (2018-04-09)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/2.1.1)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/2.1.1)

* [TASK] [issue-3] Now the folder is automatically created *(Lewis Voncken)*


## 2.1.0 (2018-02-26)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/2.1.0)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/2.1.0)

* [FEATURE] Added system xml (configuration) to enable nightly translation gathering cronjobs. Default is off, must be enabled to gather new translations on global scope every night. *(Boris van Katwijk)*
* [FEATURE] Added update function of all js-translation.json files. This function is triggered for all themes with a specific locale, on saving a translation in the missing translations section. This enables real-time updates of javascript translations for each locale active in a Magento 2 installation. *(Boris van Katwijk)*
Expand All @@ -129,7 +152,7 @@

## 2.0.0 (2018-02-21)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/2.0.0)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/2.0.0)

* [FEATURE] - Added command to add all csv translated strings to database for easy editing. Including option to include previously collected missing translations *(Ruben Panis)*
* [FEATURE] - Enabled translation grid inline editing for faster translating *(Ruben Panis)*
Expand All @@ -145,21 +168,21 @@

## 1.6.0 (2018-01-30)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.6.0)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.6.0)

* [TASK] Disabled the Translate String Button *(Lewis Voncken)*


## 1.5.0 (2018-01-30)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.5.0)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.5.0)

* [TASK] Updated labels and added notices *(Lewis Voncken)*


## 1.4.0 (2018-01-30)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.4.0)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.4.0)

* [FEATURE] Only Display Available Languages *(Lewis Voncken)*
* [TASK] Removed console.log *(Lewis Voncken)*
Expand All @@ -168,77 +191,77 @@

## 1.3.10 (2017-10-06)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.3.10)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.3.10)

* Update README.md *(Mr. Lewis)*


## 1.3.9 (2017-06-12)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.3.9)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.3.9)

* [BUGFIX] Solved problem with new string without missing strings file *(Lewis Voncken)*


## 1.3.8 (2017-06-06)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.3.8)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.3.8)

* [TASK] README.md update *(Lewis Voncken)*


## 1.3.7 (2017-06-06)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.3.7)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.3.7)

* [BUGFIX] Solved problem with empty translations in frontend and added option to translate string which is already translated *(Lewis Voncken)*


## 1.3.6 (2017-03-23)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.3.6)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.3.6)

* [TASK] Added custom delimiter for console command *(Lewis Voncken)*


## 1.3.5 (2017-03-14)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.3.5)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.3.5)

* [TASK] Updated README.md and change vendor to lower case *(Lewis Voncken)*


## 1.3.4 (2017-03-14)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.3.4)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.3.4)

* [TASK] changed the missing translations csv file *(Lewis Voncken)*


## 1.3.3 (2017-03-07)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.3.3)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.3.3)

* [TASK] Exclude UnitTests and magento2-base/dev *(Lewis Voncken)*


## 1.3.2 (2017-03-07)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.3.2)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.3.2)

* [BUGFIX] Solved compile error Extra parameters passed to parent construct: $coreRegistry. *(Lewis Voncken)*


## 1.3.1 (2017-02-28)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.3.1)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.3.1)

* [TASK] Columns update and Bugfix Edit Save *(Lewis Voncken)*


## 1.3.0 (2017-02-28)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.3.0)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.3.0)

* [FEATURE] Add Missing Translation *(Lewis Voncken)*
* [FEATURE] Translate a Missing Translation *(Lewis Voncken)*
Expand All @@ -247,7 +270,7 @@

## 1.2.0 (2017-02-17)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.2.0)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.2.0)

* [FEATURE] Added Database translations UI compnonent *(Lewis Voncken)*
* [TASK] Updated the setActiveMenu item *(Lewis Voncken)*
Expand All @@ -257,21 +280,21 @@

## 1.1.2 (2017-02-17)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.1.2)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.1.2)

* [TASK] Added extra todo to the readme *(Lewis Voncken)*


## 1.1.1 (2017-02-17)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.1.1)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.1.1)

* [TASK] Updated the README.md for correct uses with packs *(Lewis Voncken)*


## 1.1.0 (2017-02-16)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.1.0)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.1.0)

* [TASK] Changed the License *(Lewis Voncken)*
* [TASK] Changed logic to search by locale code and store id is optional for specific inline translations *(Lewis Voncken)*
Expand All @@ -281,7 +304,7 @@

## 1.0.0 (2017-02-16)

[View Release](git@github.com:experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.0.0)
[View Release](https://Basvanderlouw:104c85f1cd586500191590ee413161087a8d71f6@github.com/experius/Magento-2-Module-Experius-MissingTranslations.git/commits/tag/1.0.0)

* [TASK] Initial Commit *(Lewis Voncken)*
* [TASK] Refactor - removed Objectmanager uses from the Console Command *(Lewis Voncken)*
Expand Down
10 changes: 9 additions & 1 deletion Helper/Data.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,16 @@ public function getFileName($locale = 'en_US', $requiredExists = true)
$vendor = $this->getLanguageVendor();
$directoryPath = $this->directoryList->getRoot() . '/app/i18n/' . $vendor . '/missing/';
if (!is_dir($directoryPath)) {
mkdir($directoryPath, 0777, true);
@mkdir($directoryPath, 0777, true);
}
// Fallback for e.g., Magento Cloud, where /app directory has no write access
if (!is_dir($directoryPath)) {
$directoryPath = $this->directoryList->getRoot() . '/var/i18n/' . $vendor . '/missing/';
if (!is_dir($directoryPath)) {
@mkdir($directoryPath, 0777, true);
}
}

$filename = $directoryPath . $locale . '.csv';

return (file_exists($filename) || $requiredExists == false) ? $filename : false;
Expand Down

0 comments on commit 0bcbf34

Please sign in to comment.