-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config improvements #183
Merged
Merged
Config improvements #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apostolosfilippas
changed the title
Config improvements - DON"T MERGE!
Config improvements
Mar 29, 2024
@apostolosfilippas should I review? |
johnjosephhorton
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the new logic:
CONFIG VARS
EDSL_MAX_BACKOFF_SEC
and so on.There is a special config var,
EDSL_RUN_MODE
EDSL_RUN_MODE
, then we set it to"production"
EDSL_RUN_MODE=="production"
then all Config env vars are set to their defaultsEDSL_RUN_MODE!="production"
then we require the user to set all config env vars (in their .env, pytest.ini, or in the script)API KEYS
os.getenv()