Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config improvements #183

Merged
merged 14 commits into from
Apr 3, 2024
Merged

Config improvements #183

merged 14 commits into from
Apr 3, 2024

Conversation

apostolosfilippas
Copy link
Collaborator

Here is the new logic:

CONFIG VARS

  • Config is used only for "true" config vars -- such as EDSL_MAX_BACKOFF_SEC and so on.
  • In your code, retrieve config vars using `CONFIG.get("ENV_VAR_NAME")

There is a special config var, EDSL_RUN_MODE

  • If the user has not set EDSL_RUN_MODE, then we set it to "production"
  • If EDSL_RUN_MODE=="production" then all Config env vars are set to their defaults
  • If EDSL_RUN_MODE!="production" then we require the user to set all config env vars (in their .env, pytest.ini, or in the script)

API KEYS

  • In your code, retrieve api keys using os.getenv()

@apostolosfilippas apostolosfilippas changed the title Config improvements - DON"T MERGE! Config improvements Mar 29, 2024
@johnjosephhorton
Copy link
Contributor

@apostolosfilippas should I review?

@johnjosephhorton johnjosephhorton merged commit 60d11df into main Apr 3, 2024
6 checks passed
@apostolosfilippas apostolosfilippas deleted the config-improvements branch April 10, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants